feat: Adding Apache Kafka Kubernetes Add-on #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlyIbrahim
requested review from
askulkarni2,
csantanapr,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
AlyIbrahim
changed the title
…riment from project]
6 tasks
vara-bonthu
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
LGTM! I have fixed few formatting issues and added doc
Let's wait for one more approval @bryantbiggs , @askulkarni2
askulkarni2
reviewed
Nov 2, 2022
bryantbiggs
reviewed
Nov 2, 2022
|
@AlyIbrahim Would you be able to raise another PR for ArgoCD deployment? Here is the repo location. Please reach out if you need help. |
|
@vara-bonthu Yep, will check that |
vara-bonthu
added a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Vara Bonthu <vara.bonthu@gmail.com>
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Co-authored-by: Vara Bonthu <vara.bonthu@gmail.com>
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
Co-authored-by: Vara Bonthu <vara.bonthu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Add Strmizi Operator as a Kubernetes Add-on to be used by DoEKS for Apache Kafka on EKS
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes