Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add kubectl provider block to csi-secrets-driver example #1101

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: Add kubectl provider block to csi-secrets-driver example #1101

merged 1 commit into from
Oct 31, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add kubectl provider block to csi-secrets-driver example

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 29, 2022 00:24 Inactive
@bryantbiggs bryantbiggs merged commit a4f5b69 into main Oct 31, 2022
@bryantbiggs bryantbiggs deleted the fix/secrets-example branch October 31, 2022 19:11
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
@bryantbiggs @vara-bonthu
fix: Add kubectl provider block to csi-secrets-driver example (#1101
efaa793 
)
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@bryantbiggs @allamand
fix: Add kubectl provider block to csi-secrets-driver example (aw…
ebac2a2 
…s-ia#1101)
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@bryantbiggs @allamand
fix: Add kubectl provider block to csi-secrets-driver example (aw…
96f10ec 
…s-ia#1101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zvikan Zvikan Zvikan approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@csantanapr csantanapr Awaiting requested review from csantanapr

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubectl Provider Not mentioned for example/secrets-management/csi-secrets-driver/main.tf
2 participants
@bryantbiggs @Zvikan