feat: Istio multi primary single network blueprint #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahiduek
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
tsahiduek
changed the title
askulkarni2
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
rodrigobersa
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
askulkarni2
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
tsahiduek
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
tsahiduek
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
rodrigobersa
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
There was a problem hiding this comment.
Hey @tsahiduek
Awesome job!!
Just a a few formatting fixes. And a question about automate the validation steps.
Remember to run pre-commit run --files against each directory under your example.
tsahiduek
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
rodrigobersa
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
rodrigobersa
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a blueprint for multi-cluster Istio deployment in Multi-Primary setup
Motivation and Context
How was this change tested?
pre-commit run -awith this PRAdditional Notes
How should I run the
pre-commit run -acommand?