Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Bottlerocket pattern #1869

Merged
merged 19 commits into from
Aug 4, 2024
Merged

feat: New Bottlerocket pattern #1869

merged 19 commits into from
Aug 4, 2024

Conversation

rodrigobersa
Copy link
Contributor

@rodrigobersa rodrigobersa commented Jan 30, 2024

Description

Motivation and Context

As of today there is no patterns of how to run and customize Bottlerocket and it's Update Operator to automate CVE patching.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@rodrigobersa rodrigobersa requested a review from a team as a code owner January 30, 2024 00:19
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Some comments.

patterns/bottlerocket/README.md Outdated Show resolved Hide resolved
patterns/bottlerocket/README.md Outdated Show resolved Hide resolved
patterns/bottlerocket/addons.tf Outdated Show resolved Hide resolved
@@ -0,0 +1,152 @@
################################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why separate .tf files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is an endless discussion for defaulting patterns. Let's bring to the weekly meeting, either way works for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a decision on this one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet.

patterns/bottlerocket/karpenter-resources/Chart.yaml Outdated Show resolved Hide resolved
@rodrigobersa
Copy link
Contributor Author

Added the bottlerocket_update_operator addon.

Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 11, 2024
ebs = {
encrypted = true
kms_key_id = module.ebs_kms_key.key_arn
delete_on_termination = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future: we should show/talk about caching images on the data volume for faster pod startup. @stockholmux has more details on this

@github-actions github-actions bot removed the stale label Mar 16, 2024
@rodrigobersa rodrigobersa marked this pull request as draft March 19, 2024 13:14
@rodrigobersa rodrigobersa self-assigned this Mar 19, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 19, 2024
Copy link
Contributor

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Apr 29, 2024
@rodrigobersa rodrigobersa reopened this Jul 23, 2024
@github-actions github-actions bot removed the stale label Jul 23, 2024
@rodrigobersa rodrigobersa marked this pull request as ready for review July 23, 2024 00:11
@bryantbiggs bryantbiggs merged commit ff0c8ab into main Aug 4, 2024
7 checks passed
@bryantbiggs bryantbiggs deleted the pattern/bottlerocket branch August 4, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants