-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Bottlerocket pattern #1869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! Some comments.
@@ -0,0 +1,152 @@ | |||
################################################################################ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why separate .tf
files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is an endless discussion for defaulting patterns. Let's bring to the weekly meeting, either way works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a decision on this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet.
Added the |
This PR has been automatically marked as stale because it has been open 30 days |
ebs = { | ||
encrypted = true | ||
kms_key_id = module.ebs_kms_key.key_arn | ||
delete_on_termination = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future: we should show/talk about caching images on the data volume for faster pod startup. @stockholmux has more details on this
This PR has been automatically marked as stale because it has been open 30 days |
Pull request closed due to inactivity. |
Description
Motivation and Context
As of today there is no patterns of how to run and customize Bottlerocket and it's Update Operator to automate CVE patching.
How was this change tested?
pre-commit run -a
with this PRAdditional Notes