Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(addon): typo in gitops config for external-dns #448

Merged
merged 1 commit into from
Apr 20, 2022
Merged

bug(addon): typo in gitops config for external-dns #448

merged 1 commit into from
Apr 20, 2022

Conversation

askulkarni2
Copy link
Contributor

What does this PR do?

Typo in argocd config for external-dns.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 merged commit 698cb22 into main Apr 20, 2022
@askulkarni2 askulkarni2 deleted the askulkarni2-patch-1 branch April 20, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcoleman731 kcoleman731 kcoleman731 approved these changes

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@bryantbiggs bryantbiggs Awaiting requested review from bryantbiggs

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@askulkarni2 @kcoleman731