-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix]: #532: Have teams module honor permissions boundary #535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@askulkarni2 - Sorry! I should have caught that. Formatting should be fixed now. |
@srhoton you'll also need to update the docs for the added variable. The safest bet is to run |
Thanks for the heads up @bryantbiggs. I think I have that fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
This fixes bug #532 , and makes the teams module honor the permissions boundary in the main blueprints module.
Motivation
We hit this bug testing blueprints, and thought it was a pretty straightforward fix.
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes