Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]: #532: Have teams module honor permissions boundary #535

Merged
merged 4 commits into from
May 12, 2022

Conversation

srhoton
Copy link
Contributor

@srhoton srhoton commented May 11, 2022

What does this PR do?

This fixes bug #532 , and makes the teams module honor the permissions boundary in the main blueprints module.

Motivation

We hit this bug testing blueprints, and thought it was a pretty straightforward fix.

More

  • [ x ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srhoton thank you for this PR. Its looking good. There are some CI failures related to terraform format. You should be able to see them here.

@srhoton
Copy link
Contributor Author

srhoton commented May 12, 2022

@askulkarni2 - Sorry! I should have caught that. Formatting should be fixed now.

@bryantbiggs
Copy link
Contributor

@srhoton you'll also need to update the docs for the added variable. The safest bet is to run pre-commit run -a which will run all checks, or the fastest route for your change is just pre-commit run terraform_docs -a

@srhoton
Copy link
Contributor Author

srhoton commented May 12, 2022

Thanks for the heads up @bryantbiggs. I think I have that fixed.

Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bryantbiggs bryantbiggs merged commit 58104b2 into aws-ia:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IAM permissions boundary not passed down to teams add on
4 participants