added managed prometheus alert manager config for java/jmx modules. A… #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded additional output variable to get the managed prometheus workspace id
rameshv29
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
askulkarni2
previously requested changes
May 13, 2022
There was a problem hiding this comment.
Hi @rameshv29, thanks for the PR. Looking good.
Please run pre-commit run -a and then commit + push any changes.
|
@askulkarni2 - ran pre-commit and updated the PR. can you pls review and approve? |
bryantbiggs
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dded additional output variable to get the managed prometheus workspace id
What does this PR do?
added managed prometheus alert manager config for java/jmx modules. Added additional output variable to get the managed prometheus workspace id
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes