Fixed arm instances in the nodegroup documentation #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruecarlo
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The nodegroup documentation makes reference to ARM nodegroups. The configuration of the instances however was selecting m5.large instances instead of ARM/Graviton m6g.instances. This change just amends the configuration. In a future change I'll be happy to add a few graviton examples to the nodegroup configurations.
Motivation
While reading the configuration for nodes setup, there was a clear mistake in the selection of Graviton instances; Both examples were listing x86_64 rather than.
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes
Note: in this PR There is nothing to test at this stage; There was a mistake in the nodegroup documentation selection of ARM instances. Happy to add in a different PR a Graviton example in the nodegroup section.
While running 'terraform validate' passes the validation with success, when running pre-commit run -a , the validate phase gets stuck and after a long pause it fails as if the terraform init was not executed.