Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add launch_template_tags variable for additional launch template tags #712

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Jun 30, 2022

What does this PR do?

add "launch_template_ignore_changes" option

Motivation

If I add a tag to additional_tags, it will be added to all of them, but there was a situation where I wanted to add an arbitrary tag only to the specifications_tags of launch_template_tag, and I want to make it supported.

eg.

locals {
  shared_tags = {
    Terraform   = "true"
    Service       = "Original_Food_Shop"
  }
}

provider "aws" {
  region = var.aws_region
  default_tags {
    tags = local.shared_tags
  }
}

...
managed_node_groups = {
  mg_m5 = {
    node_group_name      = "managed-ondemand"
    instance_types       = ["m5.large"]
    subnet_ids           = module.vpc.private_subnets
    min_size             = 2
    launch_template_tags = local.shared_tags
  }
}
...

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@kahirokunn kahirokunn temporarily deployed to EKS Blueprints Test June 30, 2022 05:47 Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Thanks for the PR @kahirokunn

@vara-bonthu vara-bonthu merged commit 5b57679 into aws-ia:main Jun 30, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants