Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EBS CSI driver fix for eks v1.23 and RDS pwd fix for airflow #904

Merged
merged 3 commits into from
Aug 28, 2022
Merged

EBS CSI driver fix for eks v1.23 and RDS pwd fix for airflow #904

merged 3 commits into from
Aug 28, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Aug 28, 2022 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Closes Prometheus Add-on failed to deploy with EKS Cluster v1.23 #903
  • It's mandatory to install EBS CSI driver for all the add-on which uses GP2 storage class by default. Examples have been updated with EBS CSI driver
  • Added instructions to FAQ.doc
  • Airflow RDS database was using random password and its now fixed with the actual secrets manager password
  • Spell checks on PR template

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test August 28, 2022 11:51 Inactive
@vara-bonthu vara-bonthu merged commit 8180c9a into main Aug 28, 2022
@vara-bonthu vara-bonthu deleted the hotfix-1.23 branch August 28, 2022 12:09
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@vara-bonthu @allamand
EBS CSI driver fix for eks v1.23 and RDS pwd fix for airflow (aws-ia#904
1af5838 
)

* EBS CSI driver fix for eks v1.23 and rds fix for airflow

* Updated FAQ with v1.23 upgrade changes

* precommit updates

Co-authored-by: Bonthu <vabonthu@c889f3b8acd3.ant.amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus Add-on failed to deploy with EKS Cluster v1.23
2 participants
@vara-bonthu @bryantbiggs