Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update PR template to ensure issue is linked and clarify when examples/docs should be added #933

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add a templated line for Resolves #<xxx> to help guide users to autolink issues to PRs
  • Add clarifying note on using existing examples to demonstrate addon usage and add a docs page when adding an addon

Motivation

  • Updating project general practices

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 6, 2022 22:32 Inactive
@csantanapr
Copy link
Contributor

/lgtm

@bryantbiggs
Copy link
Contributor Author

we're not that fancy (*yet) 😅

@bryantbiggs bryantbiggs merged commit 00d16c4 into main Sep 6, 2022
@bryantbiggs bryantbiggs deleted the chore/template-issue-link branch September 6, 2022 23:04
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants