Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introducing the Portworx module to the eks add-on #955

Merged
merged 12 commits into from
Oct 11, 2022
Merged

feat: Introducing the Portworx module to the eks add-on #955

merged 12 commits into from
Oct 11, 2022

Conversation

pragrawal-px
Copy link
Contributor

@pragrawal-px pragrawal-px commented Sep 13, 2022 •
edited by askulkarni2

  • Added Portworx module, updated Kubernetes/main.tf to include the module
  • uses module from terraform registry
  • added the documentation for it

Signed-off-by: pragrawal10 pragrawal@purestorage.com
Co-authored-by: pragrawal10 pragrawal@purestorage.com

What does this PR do?

This PR introduces the Portworx, by Pure Storage add-on to the EKS blueprints repository.

Closes #959

Motivation

To enable AWS customers to manage Portworx installation in EKS with terraform using the blueprint pattern.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR
  • A new docs page under docs/add-ons/* is created for the new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@pragrawal-px
Introducing the Portworx module to the eks add-on
8dce311 
* Added Portworx module, updated Kubernetes/main.tf to include thhe module
* uses module from terraform registry

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
Co-authored-by: pragrawal10 <pragrawal@purestorage.com>

Added examples for the Portworx add-on. (#5)

* Adding a getting-started example, this example showcases the following
** creates a new EKS cluster
** Installs Portworx on it
** this examples requires explicit passing of AWS credentials

* Portworx with IAM policy example does the above but uses IAM policy instead of AWS credentials

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Ran the pre-commit check and fixed indentations (#6)

Signed-off-by: Tapas Sharma <tapas@portworx.com>

Signed-off-by: Tapas Sharma <tapas@portworx.com>
@sharma-tapas
Fixed linting errors (#7)
fb9ecf8 
Signed-off-by: Tapas Sharma <tapas@portworx.com>

Signed-off-by: Tapas Sharma <tapas@portworx.com>
askulkarni2
askulkarni2 reviewed Sep 16, 2022
View reviewed changes
docs/add-ons/portworx.md Show resolved Hide resolved
docs/add-ons/portworx.md Outdated Show resolved Hide resolved
docs/add-ons/portworx.md Outdated Show resolved Hide resolved
docs/add-ons/portworx.md Outdated Show resolved Hide resolved
examples/portworx/getting_started/README.md Outdated Show resolved Hide resolved
examples/portworx/getting_started/README.md Outdated Show resolved Hide resolved
examples/portworx/getting_started/main.tf Outdated Show resolved Hide resolved
examples/portworx/getting_started/outputs.tf Outdated Show resolved Hide resolved
examples/portworx/getting_started/variables.tf Outdated Show resolved Hide resolved
examples/portworx/portworx_with_iam_policy/README.md Outdated Show resolved Hide resolved
@pragrawal-px
Fixes for concerns raised on official PR to AWS repo (#8)
28cb91b 
* Added fixes for the suggestion on PR, updated examples and Readme

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

* Added fixes for the suggestion on PR, updated examples and Readme

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px
removed AWS credentials flow for Portworx addon, updated examples and…
e3230ae 
… docs (#9)

* removed AWS credentials part, updated documentation

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

* Updated Portworx add-on readme

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

* Updated Portworx add-on readme

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px
Updated readme for Portworx and fixed precommit issues (#10)
84678ee 
Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px pragrawal-px temporarily deployed to EKS Blueprints Test September 27, 2022 18:39 Inactive
@pragrawal-px pragrawal-px changed the title Introducing the Portworx module to the eks add-on feat: Introducing the Portworx module to the eks add-on Sep 27, 2022
askulkarni2
askulkarni2 reviewed Sep 29, 2022
View reviewed changes
modules/kubernetes-addons/main.tf Outdated Show resolved Hide resolved
examples/portworx/README.md Outdated Show resolved Hide resolved
examples/portworx/main.tf Outdated Show resolved Hide resolved
modules/kubernetes-addons/main.tf Outdated Show resolved Hide resolved
modules/kubernetes-addons/variables.tf Outdated Show resolved Hide resolved
@pragrawal-px
Changes for passing custom chart values through helm_config (#11)
547ea91 
Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px
Fixed broken hyperlinks in readme documentation (#12)
641409e 
Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px pragrawal-px temporarily deployed to EKS Blueprints Test October 10, 2022 18:03 Inactive
@pragrawal-px pragrawal-px requested review from shapirov103 and askulkarni2 and removed request for askulkarni2 and shapirov103 October 10, 2022 18:14
askulkarni2
askulkarni2 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pragrawal10 PR looks good. Please review and accept portworx/terraform-eksblueprints-portworx-addon#8. Once that is merged in, update this PR with the new module version. Then CI checks should pass and we can merge this one.

@pragrawal-px
Update Portworx addon version (#13)
97d7cb4 
Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px pragrawal-px temporarily deployed to EKS Blueprints Test October 11, 2022 13:19 Inactive
@pragrawal-px
Update Portworx version to v0.0.6 (#14)
2c076b1 
Signed-off-by: pragrawal10 <pragrawal@purestorage.com>

Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
@pragrawal-px pragrawal-px temporarily deployed to EKS Blueprints Test October 11, 2022 19:20 Inactive
@askulkarni2 askulkarni2 merged commit 2cd89ec into aws-ia:main Oct 11, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@pragrawal-px @allamand
feat: Introducing the Portworx module to the eks add-on (aws-ia#955)
ea81823 
Signed-off-by: pragrawal10 <pragrawal@purestorage.com>
Signed-off-by: Tapas Sharma <tapas@portworx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapirov103 shapirov103 shapirov103 left review comments

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADDON] Portworx addon
4 participants
@pragrawal-px @askulkarni2 @shapirov103 @sharma-tapas