Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin Terraform version to < 1.3.0 due to use of optional attribute experiment that was removed in v1.3.0 #984

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Pin Terraform version to < 1.3.0 due to use of optional attribute experiment that was removed in v1.3.0

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

…ute experiment that was removed in `v1.3.0`
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 23, 2022 21:10 Inactive
@@ -588,3 +588,5 @@ module "local_volume_provisioner" {
helm_config = var.local_volume_provisioner_helm_config
addon_context = local.addon_context
}

# whitespace noise
Copy link
Contributor Author

@bryantbiggs bryantbiggs Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just to ensure that CI picks up a diff and runs checks - will be removed in following PR

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test September 23, 2022 21:13 Inactive
@bryantbiggs bryantbiggs merged commit c98e8fd into main Sep 23, 2022
@bryantbiggs bryantbiggs deleted the fix/version-pin branch September 23, 2022 22:59
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch Templates 'locals.tf' use of 'experiments' is no longer supported in Terraform 1.3.0+
2 participants