Update docs, add markdown-spellcheck config, and refactor tests #6
Conversation
* Reword & enhance summaries * Add usage sections * Use the official source for example with a set version for optimal presentation in the Terraform Registry
* List complete input variable config in comment * Override defaults where necessary for each test * Configure external dependencies via environment variable for better developer experience
| @@ -9,13 +9,15 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| ) | |||
|
|
|||
| // You must set these environment variables for this test | |||
| const ( | |||
| user = "VSPHERE_USER" | |||
There was a problem hiding this comment.
Same query as before - the provider only supports env var configuration?
There was a problem hiding this comment.
Nope! Both environment variables and input variables are supported for configuring the vsphere provider- just like the aws & awscc providers. I had to pick one as a design decision for the examples and chose environment variables as I generally prefer to encourage not writing credentials to persistent storage- especially for those inexperienced with terraform, which are the primary audience of the examples. I included the documentation link in the comment to make it easy for customers that typically use input variables for configuring the vsphere provider credentials to learn how to use environment variables. They also have the option to edit the example locally if they prefer otherwise. :)
No description provided.