Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: Enable patch for CI #431

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

pingleig
Copy link
Member

@pingleig pingleig commented Apr 9, 2021

Description:

For aws-observability/aws-otel-test-framework#253 enable patch on all kind of tests.
Use aotutil instead of shell script to check patching status.

Link to tracking Issue:

Testing:

See aws-observability/aws-otel-test-framework#269

Documentation:

@pingleig
Copy link
Member Author

oops, since aws-observability/aws-otel-test-framework#269 is merged, we have to merge this one otherwise all the ec2 related test will start breaking cc @vastin

@pingleig pingleig requested a review from vastin April 12, 2021 17:47
Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There will be conflict in CI.yml with #436. So the PR which get merged later need to resolve conflict in CI.yml.

@pingleig
Copy link
Member Author

@vastin thanks! I think I will merge mine first because it's smaller (/w\

@pingleig pingleig merged commit 9bf5349 into aws-observability:main Apr 12, 2021
pingleig added a commit to pingleig/aws-otel-collector that referenced this pull request Apr 13, 2021
mxiamxia pushed a commit that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants