Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): remove deprecated code #1624

Merged
merged 7 commits into from
Jul 3, 2024
Merged

chore(v2): remove deprecated code #1624

merged 7 commits into from
Jul 3, 2024

Conversation

jeromevdl
Copy link
Contributor

@jeromevdl jeromevdl commented Apr 9, 2024

Issue #, if available: #1522

Description of changes:

Remove deprecated methods

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Apr 9, 2024

💾 Artifacts Size Report

Module Version Size (KB)
powertools-common 2.0.0-SNAPSHOT 9.59
powertools-serialization 2.0.0-SNAPSHOT 17.23
powertools-logging 2.0.0-SNAPSHOT 33.07
powertools-logging-log4j 2.0.0-SNAPSHOT 20.68
powertools-logging-logback 2.0.0-SNAPSHOT 16.91
powertools-tracing 2.0.0-SNAPSHOT 13.92
powertools-metrics 2.0.0-SNAPSHOT 13.74
powertools-parameters 2.0.0-SNAPSHOT 17.49
powertools-validation 2.0.0-SNAPSHOT 19.94
powertools-cloudformation 2.0.0-SNAPSHOT 16.50
powertools-idempotency-core 2.0.0-SNAPSHOT 34.63
powertools-idempotency-dynamodb 2.0.0-SNAPSHOT 12.37
powertools-large-messages 2.0.0-SNAPSHOT 17.45
powertools-batch 2.0.0-SNAPSHOT 16.89
powertools-parameters-ssm 2.0.0-SNAPSHOT 10.70
powertools-parameters-secrets 2.0.0-SNAPSHOT 9.90
powertools-parameters-dynamodb 2.0.0-SNAPSHOT 11.95
powertools-parameters-appconfig 2.0.0-SNAPSHOT 11.45

@jeromevdl jeromevdl marked this pull request as draft April 10, 2024 08:44
scottgerring
scottgerring previously approved these changes Apr 11, 2024
@scottgerring scottgerring self-requested a review April 11, 2024 17:04
@scottgerring
Copy link
Contributor

Build seems legitimately broken @jeromevdl ?

@jeromevdl jeromevdl marked this pull request as ready for review June 25, 2024 14:38
@scottgerring
Copy link
Contributor

Dangling documentation link here:

* [powertools-examples-sqs](powertools-examples-sqs) - Processes SQS batch requests (**Deprecated** - will be replaced by `powertools-examples-batch` in version 2 of this library)

Otherwise good to go!

Copy link

sonarcloud bot commented Jul 2, 2024

@jeromevdl
Copy link
Contributor Author

Dangling documentation link here:

* [powertools-examples-sqs](powertools-examples-sqs) - Processes SQS batch requests (**Deprecated** - will be replaced by `powertools-examples-batch` in version 2 of this library)

Otherwise good to go!

I've also removed some of the "main" github workflows.

@scottgerring scottgerring merged commit 749e973 into v2 Jul 3, 2024
14 checks passed
@scottgerring scottgerring deleted the chore/remove-deprecated branch July 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants