Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Event Source Data Class for CloudWatch custom connector #3499

Closed
1 of 2 tasks
corey-cole opened this issue Dec 13, 2023 · 4 comments
Closed
1 of 2 tasks
Labels
event_sources Event Source Data Class utility feature-request feature request rejected

Comments

@corey-cole
Copy link

Use case

CloudWatch metrics/alarms now support non-CloudWatch sources via an adapter Lambda function. The request/response structures are complex enough that they would benefit from having a strongly typed wrapper.

Solution/User Experience

The aws_lambda_powertools.utilities.data_classes namespace includes type for the new GetMetricData event and the corresponding MetricDataResults response.

NOTE: Although the event shares a name with an existing API call, it does not have the same structure and the existing definitions cannot be used here.

Alternative solutions

N/A

Acknowledgment

@rubenfonseca
Copy link
Contributor

Thank you so much for opening this @corey-cole ! Would you like to take a stab at the implementation, and open a PR? We can of course help you out!

@rubenfonseca rubenfonseca added event_sources Event Source Data Class utility parser Parser (Pydantic) utility and removed triage Pending triage from maintainers labels Dec 13, 2023
@rubenfonseca rubenfonseca moved this from Triage to Backlog in Powertools for AWS Lambda (Python) Dec 13, 2023
@leandrodamascena
Copy link
Contributor

Hello everyone! This feature is not planned for v2. We will add support for this after we release v3.

Adding tags to keep an eye on this.

@leandrodamascena leandrodamascena added the v3 Features that will be included in Powertools v3. label Aug 11, 2024
@leandrodamascena leandrodamascena self-assigned this Aug 11, 2024
@leandrodamascena leandrodamascena added revisit-in-3-months Requires more customers feedback before making or revisiting a decision good first issue Good for newcomers labels Aug 11, 2024
@anafalcao
Copy link
Collaborator

Closing this issue as it's been open for a while now, and we didn't have much customer feedback.
Please open a new one if it's still an issue.

@anafalcao anafalcao closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (Python) Jan 24, 2025
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added rejected and removed good first issue Good for newcomers revisit-in-3-months Requires more customers feedback before making or revisiting a decision parser Parser (Pydantic) utility v3 Features that will be included in Powertools v3. labels Jan 24, 2025
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (Python) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event_sources Event Source Data Class utility feature-request feature request rejected
Projects
Development

No branches or pull requests

5 participants