Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Remove dev dependencies locked to Pydantic v1 in the Pydantic v2 workflow #3581

Closed
1 of 2 tasks
leandrodamascena opened this issue Jan 2, 2024 · 2 comments · Fixed by #3582
Closed
1 of 2 tasks

Maintenance: Remove dev dependencies locked to Pydantic v1 in the Pydantic v2 workflow #3581

leandrodamascena opened this issue Jan 2, 2024 · 2 comments · Fixed by #3582
Assignees
@leandrodamascena
Labels
internal Maintenance changes

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

In quality_check_pydantic_v2_workflow, we are removing the dependency on cfn-lint because it just supported Pydantic v2 months ago. Now it supports Pydantic v2 and we can remove this step.

Which area does this relate to?

Automation

Solution

Remove this step.

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers internal Maintenance changes labels Jan 2, 2024
@leandrodamascena leandrodamascena self-assigned this Jan 2, 2024
@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Jan 2, 2024
@leandrodamascena leandrodamascena mentioned this issue Jan 2, 2024
Merged
7 tasks
@rubenfonseca rubenfonseca linked a pull request Jan 3, 2024 that will close this issue
chore(ci): Remove dev dependencies locked to Pydantic v1 within the Pydantic v2 workflow. #3582
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Triage to Coming soon in Powertools for AWS Lambda (Python) Jan 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jan 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This is now released under 2.31.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jan 5, 2024
@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
internal Maintenance changes
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
1 participant
@leandrodamascena