Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Static Types for AWS Lambda #149

Merged
merged 11 commits into from
Sep 3, 2020
Merged

feat: Static Types for AWS Lambda #149

merged 11 commits into from
Sep 3, 2020

Conversation

Nr18
Copy link

@Nr18 Nr18 commented Aug 29, 2020

Issue #, if available: #144

Description of changes:

Provide static types for the event and context arguments of an AWS Lambda handler

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2020

Codecov Report

Merging #149 into develop will decrease coverage by 2.15%.
The diff coverage is 78.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #149      +/-   ##
===========================================
- Coverage   100.00%   97.84%   -2.16%     
===========================================
  Files           28       33       +5     
  Lines          793      883      +90     
  Branches        72       72              
===========================================
+ Hits           793      864      +71     
- Misses           0       19      +19     
Impacted Files Coverage Δ
...ties/typing/lambda_client_context_mobile_client.py 76.19% <76.19%> (ø)
...rtools/utilities/typing/lambda_cognito_identity.py 77.77% <77.77%> (ø)
...mbda_powertools/utilities/typing/lambda_context.py 78.57% <78.57%> (ø)
...wertools/utilities/typing/lambda_client_context.py 80.00% <80.00%> (ø)
aws_lambda_powertools/utilities/typing/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28c47e...7d8a520. Read the comment docs.

@randude
Copy link

randude commented Aug 29, 2020

@heitorlessa we've been using https://pypi.org/project/aws-lambda-context/ for the lambda context static typing. it's the same thing i guess.

@Nr18
Copy link
Author

Nr18 commented Aug 29, 2020

@randude I actually am using that package today, but I wanted to start with this first then look at the gap between them.

@heitorlessa heitorlessa added area/utilities feature New feature or functionality and removed enhancement labels Aug 30, 2020
@Nr18 Nr18 marked this pull request as ready for review August 30, 2020 18:18
Copy link
Contributor

@to-mc to-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heitorlessa
Copy link
Contributor

Thanks again @Nr18 for another contribution :) Merging now, and it should be out tomorrow on 1.5.0 release \ o /

@heitorlessa heitorlessa merged commit 80a7602 into aws-powertools:develop Sep 3, 2020
@michaelbrewer
Copy link
Contributor

@Nr18 @heitorlessa - made some changes by adding tests (for cheques and balances ;) )

@Nr18
Copy link
Author

Nr18 commented Sep 3, 2020

Thanks @michaelbrewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants