-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Static Types for AWS Lambda #149
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #149 +/- ##
===========================================
- Coverage 100.00% 97.84% -2.16%
===========================================
Files 28 33 +5
Lines 793 883 +90
Branches 72 72
===========================================
+ Hits 793 864 +71
- Misses 0 19 +19
Continue to review full report at Codecov.
|
@heitorlessa we've been using https://pypi.org/project/aws-lambda-context/ for the lambda context static typing. it's the same thing i guess. |
@randude I actually am using that package today, but I wanted to start with this first then look at the gap between them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks again @Nr18 for another contribution :) Merging now, and it should be out tomorrow on 1.5.0 release \ o / |
@Nr18 @heitorlessa - made some changes by adding tests (for cheques and balances ;) ) |
Thanks @michaelbrewer |
Issue #, if available: #144
Description of changes:
Provide static types for the event and context arguments of an AWS Lambda handler
Checklist
Breaking change checklist
RFC issue #:
Migration process documentedImplement warnings (if it can live side by side)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.