Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct code examples #317

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Mar 8, 2021

Description of changes:

Changes:

  • Fix formatting for the api docs
  • Correct the data classes and idempotent code examples in the docs
  • Fix typo for sampling rate

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Michael Brewer added 2 commits March 7, 2021 19:58
Changes:
* Fix formatting for the api docs
* Correct the data classes code examples in the docs
@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Mar 8, 2021
@heitorlessa
Copy link
Contributor

Thanks a lot Michael!!

@heitorlessa heitorlessa merged commit 437ec9e into aws-powertools:develop Mar 8, 2021
@michaelbrewer michaelbrewer deleted the docs-fix-examples branch March 8, 2021 08:04
heitorlessa added a commit that referenced this pull request Mar 9, 2021
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  feat(logging): Include exception_name (#320)
  chore: remove gatsby mention as migrated completed
  refactor(parameters): Consistently reference env (#319)
  docs(metrics): remove minimum dimensions
  docs: Correct code examples (#317)
  docs(metrics): Correct code examples in markdown (#316)
  fix(idempotency): TypeError when calling is_missing_idempotency_key with an int (#315)
  docs(metrics): Corrections to the code examples (#314)
  fix(idempotency): Correctly handle save_inprogress errors (#313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants