feat: support argocd app of apps deployment

[starchx]

Issue #, if available:

#299

Description of changes:

This PR is based on @shapirov103 's branch and add App of Apps support on top.

A factory class is introduced to make it easy for our customers to enable or disable GitOps mode:

# Enable ArgoCD GitOps with each addon `Application` deployed by CDK:
ArgoGitOpsFactory.enableGitOps();

# Enable ArgoCD GitOps with all addons deployed via App of Apps:
ArgoGitOpsFactory.enableGitOpsAppOfApps();

Tested by destroying the cluster and recreating the cluster. All enabled addons were installed correctly by ArgoCD via App of Apps:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Shout out to @shapirov103 's guidance in getting this PR created.

[kcoleman731]

Thanks for this @starchx! We will definitely need some documentation updates which explain how this functionality can be used.

[shapirov103]

@starchx echoing Kevin's comment: can you please attach documentation to the PR so that reviewers understand what the new functionality is?

[starchx]

@kcoleman731 @shapirov103 Thanks for reviewing the PR. I have just added the doc with example code of how to enable GitOps mode for deploying SSP AddOns. Apologize for the delays!

During the development, I am aiming to have both CDK and Terraform consuming the same AddOns repo, which is why I also created this PR to address some consistent issues.

Any feedback are much appreciated.

[shapirov103]

@starchx thank you for making it mergeable. I was out last week, so slowly getting back. Will review this week. Thank you for the contribution!
The launch is happening next week, we are in code freeze at the moment, but it will be a fast-follow.

[shapirov103]

@starchx fantastic PR. My apologies for taking a long time to review, it was related to the release and de-facto code freeze with the exception of bug fixes and doc updates.

[shapirov103]

I also was thinking about an approach for non helm add-ons (just k8s manifests that we could deploy with some templating/kustomize) that could also be gitops driven. This is for later though, but let me know if you saw any customers asking for it.

[starchx]

Good callout. Will definitely keep eye on this. Going through the current blueprint addon list, these are the only two not using HelmAddOn: (exclude those EKS managed addons)

• SSM Addon
• XRay Addon

[shapirov103]

Yeah, I hope it will be less and less. Such add-ons may be, however, custom. SSM and XRay standalone are less of a concern for me atm. XRay support is available through AppMesh add-on (enableTracing).

[starchx]

Thanks again for the PR review @shapirov103 ☺️

All the suggestions are very good and making sense. I have updated the PR ready.

There is only one comment on this one: #300 (comment)

When you have time 🙂

[shapirov103]

All looks great!

ArgoCD merging of values is reasonable. It can enable customers to pass additional values to the app of apps from add-on, so no disagreement.

Now we need to solve the approach for testing it. Ideally I would like to have three clusters in the e2e tests created: 1/ imperative add-ons through CDK (many customers will use just that), 2/ declarative GitOps with app of apps 3/ declarative GitOps with apps.

The above is ideal as I mentioned. To merge this, we can add pattern to the patterns repo for both approaches. This will however, require a version increment for this artifact.

So we have two options:

1. e2e with 3 clusters
2. a simpler approach with a pattern in the patterns repo.

Regardless, let's bump the version up to 1.1.0 - I am thinking a minor release.

[shapirov103]

Yeah, I hope it will be less and less. Such add-ons may be, however, custom. SSM and XRay standalone are less of a concern for me atm. XRay support is available through AppMesh add-on (enableTracing).

[starchx]

@shapirov103 , I am closing this PR in favor of #588