Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scad to cur #794

Merged
merged 5 commits into from
May 15, 2024
Merged

add scad to cur #794

merged 5 commits into from
May 15, 2024

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cfn-templates/cur-aggregation.yaml Dismissed Show dismissed Hide dismissed
cfn-templates/cur-aggregation.yaml Dismissed Show dismissed Hide dismissed
@MaximF
Copy link
Contributor

MaximF commented Apr 24, 2024

@iakov-aws I'm looking forward to getting this PR ready and merged into the main branch!

BTW, applying the changes from the branch as of now is resulting into this error message:

ValidationError: Parameters: [AddSCAD] do not exist in the template

@MaximF
Copy link
Contributor

MaximF commented May 2, 2024

@iakov-aws I created a PR #808 to your current branch to activate SPLIT_COST_ALLOCATION_DATA. Could you please take a look?

@yamb00
Copy link

yamb00 commented May 14, 2024

@iakov-aws could you please rebase this MR to fix the terraform-scan. You already merged the woraround. And is something else missing? I'm looking forward to deploy SCAD over the tf-module

@iakov-aws
Copy link
Collaborator Author

Not sure what is needed AWS is a member of FinOps foundation but the site says it is not. Help in the processs would be appreaciated

@iakov-aws iakov-aws merged commit 88938fa into main May 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants