Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding iceberg support #132

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Adding iceberg support #132

merged 4 commits into from
Jan 17, 2023

Conversation

mehdimld
Copy link
Collaborator

@mehdimld mehdimld commented Jan 17, 2023 •
edited
Loading

resolves #

Description

In response to comments on previously merged PR (#130) this PR :

  • adds details on Iceberg documentation (provide details on commit locking, catalog alias. provide least privilege IAM permissions for DynamoDB Commit Locking. Correct typos)
  • adds customizable DynamoDB table name for Iceberg Commit Locking.
  • performs refactoring of unused --conf parameter for Iceberg file format (warehouse_path)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@menuetb menuetb merged commit 6467fa9 into aws-samples:main Jan 17, 2023
@mehdimld mehdimld mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehdimld @menuetb