Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double quote bug #327

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

moomindani
Copy link
Collaborator

resolves #311

Description

This PR is to fix the issue that removes double quote unexpectedly.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moomindani moomindani added the enable-functional-tests This label enable functional tests label Jan 31, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@moomindani moomindani mentioned this pull request Feb 1, 2024
4 tasks
Copy link
Contributor

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Would you fix the conflict?

@moomindani moomindani merged commit 8ca0eda into aws-samples:main Feb 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-functional-tests This label enable functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt-glue removes double quotes from sql models
2 participants