This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
Add Automatic Container Instance Draining during ASG Scale-Down Event #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improved lambda function yaml syntax
documentation updated for lifecyclehook
use env var in lambda function
PaulMaddox
approved these changes
Mar 5, 2018
|
❤️ this! Awesome contribution. |
wichert
reviewed
Apr 4, 2018
| - LifecycleHandlerFunction | ||
| - Arn | ||
| Protocol: lambda | ||
| DependsOn: LifecycleHandlerFunction |
There was a problem hiding this comment.
Is that DependsOn necessary? I think the !GetAtt automatically creates a dependency?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New stack "LifecycleHook" (*must put lifecyclehook.yaml into S3 Bucket, to be available at https://s3.amazonaws.com/ecs-refarch-cloudformation/infrastructure/lifecyclehook.yaml)
Before a Container Instance in the Autoscaling Group is terminated (due to scale-in), it will enter Terminating:Wait lifecycle hook.
Lambda function will drain running Tasks from container Instances where possible, and send complete_lifecycle_action to ASG when no Tasks are running/pending on Instance.