Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This implement Crop feature in Thumbor urls #202

Closed
wants to merge 3 commits into from

Conversation

atrope
Copy link

@atrope atrope commented Apr 7, 2020

Description of changes:
This is a non-breaking change.
Had to do this because we had old Thumbor urls with the Crop filter of the type AxB:C:D

example:
https://images.suamusica.com.br/2Qv9xzqA2y7kOZq0g5dH4vh_WRM=/100x10:200x200/news/15a4005828a5d09c2d0dccb26b93b46b.jpg
https://images.suamusica.com.br/C4sC0GU5azPokmy0In07_F_owyY=/news/15a4005828a5d09c2d0dccb26b93b46b.jpg
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pruhstal
Copy link

@atrope nice one! was just implementing this myself, and then stumbled upon this. @georgebearden any chance this could make it in the next release?

@Furytron
Copy link

It would be great to see this in a new release. I see there are conflicts with that regex in image-request.js. Definitely care needs to be taken changing that regex. See: #187 (comment)

@Furytron
Copy link

Furytron commented Jul 7, 2021

Just to add, the following filters should be included as supported with the cropping

https://thumbor.readthedocs.io/en/latest/extract_focal_points.html
https://thumbor.readthedocs.io/en/latest/focal.html

@gattasrikanth
Copy link

Thank you for the feedback and the PR. I have added this to our backlog queue.

@fisenkodv
Copy link
Contributor

@atrope, thank you for your contribution.
We have updated our solution, and your pull request has been merged into our main branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here.

@fisenkodv fisenkodv closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants