Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent version 1.15.2 #1078

Merged
merged 3 commits into from
Nov 17, 2017
Merged

Agent version 1.15.2 #1078

merged 3 commits into from
Nov 17, 2017

Conversation

nmeyerhans
Copy link
Contributor

@nmeyerhans nmeyerhans commented Nov 15, 2017 •
edited
Loading

Summary

  • Bug - Fixed a bug where container state information wasn't reported. #1076

richardpen
richardpen reviewed Nov 15, 2017
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,8 @@
#Changelog

## 1.15.2
* Bug - Fixed a bug where container state information wasn't reported. [#1067](https://github.com/aws/amazon-ecs-agent/pull/1067)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the number, it should be 1076.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

jhaynes
jhaynes reviewed Nov 15, 2017
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,8 @@
#Changelog

## 1.15.2
* Bug - Fixed a bug where container state information wasn't reported. [#1067](https://github.com/aws/amazon-ecs-agent/pull/1067)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should be #1076 rather than #1067.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and done (again)

jhaynes
jhaynes approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@jhaynes jhaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update your summary to reflect the #1067 vs #1076 change. But lgtm.

@nmeyerhans nmeyerhans merged commit ea58fdd into aws:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpen richardpen richardpen approved these changes

@jhaynes jhaynes jhaynes approved these changes

@aaithal aaithal aaithal approved these changes

@jahkeup jahkeup jahkeup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nmeyerhans @jahkeup @aaithal @jhaynes @richardpen