Add volume to rpm/deb package #478
Conversation
Realmonia
force-pushed
the
addVolumeToRpmPackage
branch
from
5a21db4
to
80c642a
Compare
| @@ -0,0 +1,23 @@ | |||
| # Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Q. should it be updated to Copyright 2022 Amazon.com, Inc for
- packaging/generic-rpm/amazon-ecs-volume-plugin.service
- packaging/generic-rpm/amazon-ecs-volume-plugin.socket
- packaging/generic-deb/debian/amazon-ecs-volume-plugin.service
- packaging/generic-deb/debian/amazon-ecs-volume-plugin.socket ?
Thanks.
There was a problem hiding this comment.
Q. should we reuse existing amazon-ecs-volume-plugin.service and amazon-ecs-volume-plugin.socket in the amazon-linux-ami folder instead of creating new files? Thanks.
There was a problem hiding this comment.
should we reuse existing amazon-ecs-volume-plugin.service and amazon-ecs-volume-plugin.socket in the amazon-linux-ami folder instead of creating new files?
I see that all the packaging folders have their own ecs.service file as well, I'm not sure if the reason behind might this was to make the packaging folders to be self contained but ya I do not have a preference in this.
There was a problem hiding this comment.
Updated all touched files to 2022. For the existing files my thought is same as Mythri's idea to have each packaging folders self contained and could be separated easily if we want to have different build root. And in case we have different setups for different platforms we gain more flexibilities on it. Users making their own packages could also easily understand the hierarchy and only modify stuff under the platform they concern.
Realmonia
force-pushed
the
addVolumeToRpmPackage
branch
from
255179a
to
c31f11c
Compare
Summary
This PR cherry-picks the previous volume plugin updates commits, and remove the curl line which breaks during release init build, also updates the readme for customized rpm build
Implementation details
See previous PRs #450 and #462
Testing
New tests cover the changes: N/A
Tests done for pr #450 and #462 :
Tests done for fixing the release build failure: test build in shadow stage pipeline
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: