Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end to end tests and some other improvements #90

Merged
merged 23 commits into from
Mar 26, 2023

Conversation

YashdalfTheGray
Copy link
Contributor

@YashdalfTheGray YashdalfTheGray commented Mar 20, 2023

Description of changes:

  • added a log collector workflow that will pull failed CNI plugin tests log and attach them as artifacts
  • added a TESTING.md file that goes over some of the testing setup
  • migrated ioutil to os calls
  • changed all of the tests to have unique network namespaces
  • updated vpc-tunnel test to pass the right arguments to exec
  • added the right required setup (creating eth1 and eth2 dummy links) to the github workflow
  • use a different set of inputs for the TestAddDelBlockIMDS test and the TestAddDel test
  • added a template builder and fields map to make the vpc-branch-eni tests read a little better

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@YashdalfTheGray YashdalfTheGray marked this pull request as draft March 20, 2023 20:09
@YashdalfTheGray YashdalfTheGray marked this pull request as ready for review March 22, 2023 09:26
@YashdalfTheGray YashdalfTheGray changed the title [WIP] Fix end to end tests Fix end to end tests and some other improvements Mar 22, 2023
}
}

func validateAfterAddCommon(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just have validateAfterAddCommon and remove the above validateAfterAdd ?

Copy link
Contributor

@ofiliz ofiliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes and other improvements.

We should consider renaming "e2e-tests" to "func-test" or whatever ecs-agent uses to use the same terminology and possibly even the same Make targets. But that can be addressed later in a separate PR.

@ofiliz ofiliz merged commit 646f7d7 into aws:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants