-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix end to end tests and some other improvements #90
Conversation
} | ||
} | ||
|
||
func validateAfterAddCommon( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just have validateAfterAddCommon and remove the above validateAfterAdd ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these fixes and other improvements.
We should consider renaming "e2e-tests" to "func-test" or whatever ecs-agent uses to use the same terminology and possibly even the same Make targets. But that can be addressed later in a separate PR.
Description of changes:
TESTING.md
file that goes over some of the testing setupioutil
toos
callseth1
andeth2
dummy links) to the github workflowTestAddDelBlockIMDS
test and theTestAddDel
testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.