Skip to content

Commit 10c37dd

Browse files
authored
refactor(lambda): renamed the lambda.Runtime enum values from NodeJS to Nodejs (#2815)
Addresses the consistency of casing for runtime for other target languages. in Python, this was previously `NODE_J_S` and now it will be `NODEJS` **Fixes #980** BREAKING CHANGE: * **lambda:** `lambda.Runtime.NodeJS*` are now `lambda.Runtime.Nodejs*`
1 parent 9270ceb commit 10c37dd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+116
-116
lines changed

packages/@aws-cdk/assets-docker/lib/adopted-repository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class AdoptedRepository extends ecr.RepositoryBase {
3333
super(scope, id);
3434

3535
const fn = new lambda.SingletonFunction(this, 'Function', {
36-
runtime: lambda.Runtime.NodeJS810,
36+
runtime: lambda.Runtime.Nodejs810,
3737
lambdaPurpose: 'AdoptEcrRepository',
3838
handler: 'handler.handler',
3939
code: lambda.Code.asset(path.join(__dirname, 'adopt-repository')),

packages/@aws-cdk/aws-apigateway/test/integ.restapi.books.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ class BookStack extends cdk.Stack {
77
super(scope, id);
88

99
const booksHandler = new apigw.LambdaIntegration(new lambda.Function(this, 'BooksHandler', {
10-
runtime: lambda.Runtime.NodeJS810,
10+
runtime: lambda.Runtime.Nodejs810,
1111
handler: 'index.handler',
1212
code: lambda.Code.inline(`exports.handler = ${echoHandlerCode}`)
1313
}));
1414

1515
const bookHandler = new apigw.LambdaIntegration(new lambda.Function(this, 'BookHandler', {
16-
runtime: lambda.Runtime.NodeJS810,
16+
runtime: lambda.Runtime.Nodejs810,
1717
handler: 'index.handler',
1818
code: lambda.Code.inline(`exports.handler = ${echoHandlerCode}`)
1919
}));
2020

2121
const hello = new apigw.LambdaIntegration(new lambda.Function(this, 'Hello', {
22-
runtime: lambda.Runtime.NodeJS810,
22+
runtime: lambda.Runtime.Nodejs810,
2323
handler: 'index.handler',
2424
code: lambda.Code.inline(`exports.handler = ${helloCode}`)
2525
}));

packages/@aws-cdk/aws-apigateway/test/integ.restapi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class Test extends cdk.Stack {
2323
});
2424

2525
const handler = new lambda.Function(this, 'MyHandler', {
26-
runtime: lambda.Runtime.NodeJS810,
26+
runtime: lambda.Runtime.Nodejs810,
2727
code: lambda.Code.inline(`exports.handler = ${handlerCode}`),
2828
handler: 'index.handler',
2929
});

packages/@aws-cdk/aws-apigateway/test/test.lambda-api.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export = {
1414
const handler = new lambda.Function(stack, 'handler', {
1515
handler: 'index.handler',
1616
code: lambda.Code.inline('boom'),
17-
runtime: lambda.Runtime.NodeJS810,
17+
runtime: lambda.Runtime.Nodejs810,
1818
});
1919

2020
// WHEN
@@ -78,7 +78,7 @@ export = {
7878
const handler = new lambda.Function(stack, 'handler', {
7979
handler: 'index.handler',
8080
code: lambda.Code.inline('boom'),
81-
runtime: lambda.Runtime.NodeJS810,
81+
runtime: lambda.Runtime.Nodejs810,
8282
});
8383
const alias = new lambda.Alias(stack, 'alias', {
8484
aliasName: 'my-alias',
@@ -145,7 +145,7 @@ export = {
145145
const handler = new lambda.Function(stack, 'handler', {
146146
handler: 'index.handler',
147147
code: lambda.Code.inline('boom'),
148-
runtime: lambda.Runtime.NodeJS810,
148+
runtime: lambda.Runtime.Nodejs810,
149149
});
150150

151151
// WHEN
@@ -184,7 +184,7 @@ export = {
184184
const handler = new lambda.Function(stack, 'handler', {
185185
handler: 'index.handler',
186186
code: lambda.Code.inline('boom'),
187-
runtime: lambda.Runtime.NodeJS810,
187+
runtime: lambda.Runtime.Nodejs810,
188188
});
189189

190190
test.throws(() => new apigw.LambdaRestApi(stack, 'lambda-rest-api', {

packages/@aws-cdk/aws-apigateway/test/test.lambda.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export = {
5656
// GIVEN
5757
const stack = new cdk.Stack();
5858
const fn = new lambda.Function(stack, 'Handler', {
59-
runtime: lambda.Runtime.NodeJS810,
59+
runtime: lambda.Runtime.Nodejs810,
6060
code: lambda.Code.inline('foo'),
6161
handler: 'index.handler'
6262
});
@@ -106,7 +106,7 @@ export = {
106106
// GIVEN
107107
const stack = new cdk.Stack();
108108
const fn = new lambda.Function(stack, 'Handler', {
109-
runtime: lambda.Runtime.NodeJS810,
109+
runtime: lambda.Runtime.Nodejs810,
110110
code: lambda.Code.inline('foo'),
111111
handler: 'index.handler'
112112
});
@@ -132,7 +132,7 @@ export = {
132132
const api = new apigateway.RestApi(stack, 'test-api');
133133

134134
const handler = new lambda.Function(stack, 'MyFunc', {
135-
runtime: lambda.Runtime.NodeJS810,
135+
runtime: lambda.Runtime.Nodejs810,
136136
handler: 'index.handler',
137137
code: lambda.Code.inline(``)
138138
});

packages/@aws-cdk/aws-autoscaling-hooktargets/test/hooks.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe('given an AutoScalingGroup', () => {
5757
// GIVEN
5858
const fn = new lambda.Function(stack, 'Fn', {
5959
code: lambda.Code.inline('foo'),
60-
runtime: lambda.Runtime.NodeJS810,
60+
runtime: lambda.Runtime.Nodejs810,
6161
handler: 'index.index',
6262
});
6363

packages/@aws-cdk/aws-certificatemanager/lib/dns-validated-certificate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class DnsValidatedCertificate extends cdk.Resource implements ICertificat
5050
const requestorFunction = new lambda.Function(this, 'CertificateRequestorFunction', {
5151
code: lambda.Code.asset(path.resolve(__dirname, '..', 'lambda-packages', 'dns_validated_certificate_handler', 'lib')),
5252
handler: 'index.certificateRequestHandler',
53-
runtime: lambda.Runtime.NodeJS810,
53+
runtime: lambda.Runtime.Nodejs810,
5454
timeout: 15 * 60 // 15 minutes
5555
});
5656
requestorFunction.addToRolePolicy(

packages/@aws-cdk/aws-cloudformation/lib/aws-custom-resource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export class AwsCustomResource extends cdk.Construct {
123123

124124
const provider = new lambda.SingletonFunction(this, 'Provider', {
125125
code: lambda.Code.asset(path.join(__dirname, 'aws-custom-resource-provider')),
126-
runtime: lambda.Runtime.NodeJS10x,
126+
runtime: lambda.Runtime.Nodejs10x,
127127
handler: 'index.handler',
128128
uuid: '679f53fa-c002-430c-b0da-5b7982bd2287',
129129
lambdaPurpose: 'AWS'

packages/@aws-cdk/aws-codedeploy/test/lambda/integ.deployment-group.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const stack = new cdk.Stack(app, 'aws-cdk-codedeploy-lambda');
1111
const handler = new lambda.Function(stack, `Handler`, {
1212
code: lambda.Code.asset(path.join(__dirname, 'handler')),
1313
handler: 'index.handler',
14-
runtime: lambda.Runtime.NodeJS810,
14+
runtime: lambda.Runtime.Nodejs810,
1515
});
1616
const version = handler.addVersion('1');
1717
const blueGreenAlias = new lambda.Alias(stack, `Alias`, {
@@ -22,12 +22,12 @@ const blueGreenAlias = new lambda.Alias(stack, `Alias`, {
2222
const preHook = new lambda.Function(stack, `PreHook`, {
2323
code: lambda.Code.asset(path.join(__dirname, 'preHook')),
2424
handler: 'index.handler',
25-
runtime: lambda.Runtime.NodeJS810
25+
runtime: lambda.Runtime.Nodejs810
2626
});
2727
const postHook = new lambda.Function(stack, `PostHook`, {
2828
code: lambda.Code.asset(path.join(__dirname, 'postHook')),
2929
handler: 'index.handler',
30-
runtime: lambda.Runtime.NodeJS810
30+
runtime: lambda.Runtime.Nodejs810
3131
});
3232

3333
new codedeploy.LambdaDeploymentGroup(stack, 'BlueGreenDeployment', {

packages/@aws-cdk/aws-codedeploy/test/lambda/test.deployment-group.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function mockFunction(stack: cdk.Stack, id: string) {
1111
return new lambda.Function(stack, id, {
1212
code: lambda.Code.inline('mock'),
1313
handler: 'index.handler',
14-
runtime: lambda.Runtime.NodeJS810
14+
runtime: lambda.Runtime.Nodejs810
1515
});
1616
}
1717
function mockAlias(stack: cdk.Stack) {

0 commit comments

Comments
 (0)