fix(ecr): set correct resource policy for ecr repository (#3590)

* fix(ecr): set correct resource policy for ecr repository * Use the full ARN of the repository in the ECR policy This fixes the aws-ecr-assets test where an IAM user receives the policy instead of the ECR repository. * Remove resource statement when resource policy is changed
aws · Aug 19, 2019 · 30f3968 · 30f3968
1 parent 8d3cf77
commit 30f3968
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/packages/@aws-cdk/aws-ecr/lib/repository.ts b/packages/@aws-cdk/aws-ecr/lib/repository.ts
@@ -179,7 +179,7 @@ export abstract class RepositoryBase extends Resource implements IRepository {
       grantee,
       actions,
       resourceArns: [this.repositoryArn],
-      resourceSelfArns: ['*'],
+      resourceSelfArns: [],
       resource: this,
     });
   }

diff --git a/packages/@aws-cdk/aws-ecr/test/test.repository.ts b/packages/@aws-cdk/aws-ecr/test/test.repository.ts
@@ -377,7 +377,6 @@ export = {
             ],
             "Effect": "Allow",
             "Principal": "*",
-            "Resource": "*",
           }
         ],
         "Version": "2012-10-17"