fix(ecr): set correct resource policy for ecr repository (#3590)

Sander Knape · mergify[bot] · commit 30f3968a0d3a · 2019-08-19T14:03:42.000Z
* fix(ecr): set correct resource policy for ecr repository

* Use the full ARN of the repository in the ECR policy

This fixes the aws-ecr-assets test where an IAM user receives the policy instead of the ECR repository.

* Remove resource statement when resource policy is changed
diff --git a/packages/@aws-cdk/aws-ecr/lib/repository.ts b/packages/@aws-cdk/aws-ecr/lib/repository.ts
@@ -179,7 +179,7 @@ export abstract class RepositoryBase extends Resource implements IRepository {
       grantee,
       actions,
       resourceArns: [this.repositoryArn],
-      resourceSelfArns: ['*'],
+      resourceSelfArns: [],
       resource: this,
     });
   }
diff --git a/packages/@aws-cdk/aws-ecr/test/test.repository.ts b/packages/@aws-cdk/aws-ecr/test/test.repository.ts
@@ -377,7 +377,6 @@ export = {
             ],
             "Effect": "Allow",
             "Principal": "*",
-            "Resource": "*",
           }
         ],
         "Version": "2012-10-17"

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ export abstract class RepositoryBase extends Resource implements IRepository {`
`179`	`179`	`grantee,`
`180`	`180`	`actions,`
`181`	`181`	`resourceArns: [this.repositoryArn],`
`182`		`- resourceSelfArns: ['*'],`
	`182`	`+ resourceSelfArns: [],`
`183`	`183`	`resource: this,`
`184`	`184`	`});`
`185`	`185`	`}`
Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,6 @@ export = {`
`377`	`377`	`],`
`378`	`378`	`"Effect": "Allow",`
`379`	`379`	`"Principal": "*",`
`380`		`- "Resource": "*",`
`381`	`380`	`}`
`382`	`381`	`],`
`383`	`382`	`"Version": "2012-10-17"`