Skip to content

Commit 42876e7

Browse files
authored
fix: Npm ignores files and folders named "core" by default (#1767)
Since the release of `npm@6.8.0`, a version of `npm-packlist` is included that introduces a behavior to ignore anything named "core" by default. Added `!core` to the `.npmignore` file as a work around, and also more strictly pinned the `npm` version to auto-upgrade to so we don't get surprised in this kind of way anymore. Cause: npm/npm-packlist#24
1 parent 73d5bef commit 42876e7

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS:-}"
55

66
if ! npm ci --help; then
77
echo "upgrading npm, because "npm ci" is not supported"
8-
npm i -g npm
8+
npm i -g npm@~6.8.0
99
fi
1010

1111
echo "============================================================================================="

packages/@aws-cdk/cdk/.npmignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,7 @@ dist
1313
# Include .jsii
1414
!.jsii
1515

16-
*.snk
16+
*.snk
17+
18+
# Work around npm@6.8.0 ignoring 'core' by default -- https://github.com/npm/npm-packlist/issues/24
19+
!core

0 commit comments

Comments
 (0)