fix(events): allow adding same target to rule multiple times (#3353)

As rule targets can have different input configurations adding the same target multiple times
must be possible.

Move rule target id generation to `aws-events` where it's easy to simply increment a counter. This
id is passed as an argument to `bind()` for targets that need to know their given id (e.g. `EcsTask`).

Add `permissionsNode` on `IFunction` to handle permission checks for both functions and singleton functions.

Fixes #3173

Author: rix0rrr

packages/@aws-cdk/aws-cloudtrail/test/test.cloudtrail.ts

@@ -200,8 +200,8 @@ export = {
     trail.onCloudTrailEvent('DoEvents', {
       target: {
         bind: () => ({
+          id: '',
           arn: 'arn',
-          id: 'myid'
         })
       }
     });
@@ -217,7 +217,7 @@ export = {
       Targets: [
         {
           Arn: "arn",
-          Id: "myid"
+          Id: "Target0"
         }
       ]
     }));

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-events.expected.json

@@ -37,7 +37,7 @@
             "Arn": {
               "Ref": "MyTopic86869434"
             },
-            "Id": "MyTopic"
+            "Id": "Target0"
           }
         ]
       }
@@ -46,4 +46,4 @@
       "Type": "AWS::SNS::Topic"
     }
   }
-}
+}

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-events.ts

@@ -16,7 +16,7 @@ repo.onReferenceCreated('OnReferenceCreated', {
   target: {
     bind: () => ({
       arn: topic.topicArn,
-      id: 'MyTopic'
+      id: ''
     })
   }
 });

packages/@aws-cdk/aws-codepipeline-actions/test/integ.lambda-deployed-through-codepipeline.lit.expected.json

@@ -1196,7 +1196,7 @@
                 ]
               ]
             },
-            "Id": "PipelineStackPipeline9DB740AF",
+            "Id": "Target0",
             "RoleArn": {
               "Fn::GetAtt": [
                 "PipelineEventsRole46BEEA7C",
@@ -1268,7 +1268,7 @@
                 ]
               ]
             },
-            "Id": "PipelineStackPipeline9DB740AF",
+            "Id": "Target0",
             "RoleArn": {
               "Fn::GetAtt": [
                 "PipelineEventsRole46BEEA7C",

packages/@aws-cdk/aws-codepipeline-actions/test/integ.lambda-pipeline.expected.json

@@ -638,7 +638,7 @@
                 ]
               ]
             },
-            "Id": "awscdkcodepipelinelambdaPipeline87A4B3D3",
+            "Id": "Target0",
             "RoleArn": {
               "Fn::GetAtt": [
                 "PipelineEventsRole46BEEA7C",

packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-code-build-multiple-inputs-outputs.expected.json

@@ -61,7 +61,7 @@
                 ]
               ]
             },
-            "Id": "awscdkcodepipelinecodebuildmultipleinputsoutputsPipeline314D3A85",
+            "Id": "Target0",
             "RoleArn": {
               "Fn::GetAtt": [
                 "PipelineEventsRole46BEEA7C",

packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-code-commit.expected.json

@@ -61,7 +61,7 @@
                 ]
               ]
             },
-            "Id": "awscdkcodepipelinecodecommitPipelineF780CA18",
+            "Id": "Target0",
             "RoleArn": {
               "Fn::GetAtt": [
                 "PipelineEventsRole46BEEA7C",

packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-ecr-source.expected.json

@@ -423,7 +423,7 @@
                 ]
               ]
             },
-            "Id": "awscdkcodepipelineecrsourceMyPipeline63CF3194",
+            "Id": "Target0",
             "RoleArn": {
               "Fn::GetAtt": [
                 "MyPipelineEventsRoleFAB99F32",

packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-events.expected.json

@@ -510,7 +510,7 @@
             "Arn": {
               "Ref": "MyTopic86869434"
             },
-            "Id": "awscdkpipelineeventtargetMyTopic8D32776A"
+            "Id": "Target0"
           }
         ]
       }
@@ -562,7 +562,7 @@
             "Arn": {
               "Ref": "MyTopic86869434"
             },
-            "Id": "awscdkpipelineeventtargetMyTopic8D32776A"
+            "Id": "Target0"
           }
         ]
       }
@@ -671,7 +671,7 @@
             "Arn": {
               "Ref": "MyTopic86869434"
             },
-            "Id": "awscdkpipelineeventtargetMyTopic8D32776A",
+            "Id": "Target0",
             "InputTransformer": {
               "InputPathsMap": {
                 "detail-pipeline": "$.detail.pipeline",

packages/@aws-cdk/aws-codepipeline-actions/test/test.pipeline.ts

@@ -365,7 +365,7 @@ export = {
         "Arn": {
           "Ref": "TopicBFC7AF6E"
         },
-        "Id": "Topic"
+        "Id": "Target0"
         }
       ]
     }));