Skip to content

Commit 602bac2

Browse files
Jimmy Gaussenmergify[bot]
authored andcommitted
fix(appmesh): actually set listener healthCheck.path (#4218)
1 parent 3a9f4c8 commit 602bac2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ function renderHealthCheck(hc: HealthCheck | undefined, pm: PortMapping): CfnVir
153153
return {
154154
healthyThreshold: hc.healthyThreshold || 2,
155155
intervalMillis: (hc.interval || cdk.Duration.seconds(5)).toMilliseconds(), // min
156-
path: hc.path || hc.protocol === Protocol.HTTP ? '/' : undefined,
156+
path: hc.path || (hc.protocol === Protocol.HTTP ? '/' : undefined),
157157
port: hc.port || pm.port,
158158
protocol: hc.protocol || pm.protocol,
159159
timeoutMillis: (hc.timeout || cdk.Duration.seconds(2)).toMilliseconds(),

packages/@aws-cdk/aws-appmesh/test/integ.mesh.expected.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@
655655
"HealthCheck": {
656656
"HealthyThreshold": 3,
657657
"IntervalMillis": 5000,
658-
"Path": "/",
658+
"Path": "/check-path",
659659
"Port": 8080,
660660
"Protocol": "http",
661661
"TimeoutMillis": 2000,
@@ -710,7 +710,7 @@
710710
"HealthCheck": {
711711
"HealthyThreshold": 3,
712712
"IntervalMillis": 5000,
713-
"Path": "/",
713+
"Path": "/check-path2",
714714
"Port": 8080,
715715
"Protocol": "http",
716716
"TimeoutMillis": 2000,
@@ -753,7 +753,7 @@
753753
"HealthCheck": {
754754
"HealthyThreshold": 3,
755755
"IntervalMillis": 5000,
756-
"Path": "/",
756+
"Path": "/check-path3",
757757
"Port": 8080,
758758
"Protocol": "http",
759759
"TimeoutMillis": 2000,

0 commit comments

Comments
 (0)