Skip to content

Commit 6184423

Browse files
author
Elad Ben-Israel
authored
feat(core): only include cdk libs in version reporting (#1290)
Include only libraries with names that start with "@aws-cdk", "aws-cdk" or "jsii-". Fixes awslabs/cdk-ops#172
1 parent f06de18 commit 6184423

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

packages/@aws-cdk/cdk/lib/app.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,13 @@ export class App extends Root {
133133
}
134134
}
135135

136+
// include only libraries that are in the @aws-cdk npm scope
137+
for (const name of Object.keys(libraries)) {
138+
if (!name.startsWith('@aws-cdk/')) {
139+
delete libraries[name];
140+
}
141+
}
142+
136143
// add jsii runtime version
137144
libraries['jsii-runtime'] = getJsiiAgentVersion();
138145

packages/@aws-cdk/cdk/test/test.app.ts

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,25 @@ export = {
296296

297297
delete process.env.JSII_AGENT;
298298
test.done();
299-
}
299+
},
300+
301+
'version reporting includes only @aws-cdk, aws-cdk and jsii libraries'(test: Test) {
302+
const response = withApp({}, app => {
303+
const stack = new Stack(app, 'stack1');
304+
new Resource(stack, 'MyResource', { type: 'Resource::Type' });
305+
});
306+
307+
const libs = response.runtime.libraries;
308+
309+
const version = require('../package.json').version;
310+
test.deepEqual(libs, {
311+
'@aws-cdk/cdk': version,
312+
'@aws-cdk/cx-api': version,
313+
'jsii-runtime': `node.js/${process.version}`
314+
});
315+
316+
test.done();
317+
},
300318
};
301319

302320
class MyConstruct extends Construct {

0 commit comments

Comments
 (0)