refactor(core): additional api cleanups (#2972)

Additional minor API cleanups in the core module (see breaking changes list).

Updated physical names linter rule to verify that physical name property name is
`cfnTypeName` and that it's type is either `PhysicalName` in case the name is
optional and `string` if the name is required (fixes #2971).

Moved all internal files in @aws-cdk/cdk under "private"

BREAKING CHANGE: The deprecated `app.run()` has been removed (use `app.synth()`).
* **core:** `CfnElement.refAsString` renamed to `ref` of `string` type. The `IResolvable` version have been removed.
* **core:** `Resource.physicalName` is now a `string` instead of `PhysicalName`. If a physical name should be generated during deployment (i.e. not supplied to L1), the string will synthesize to `undefined`.
* **core:** `IStringValue` renamed to `IStringProducer`
* **core:** `Include` renamed to `CfnInclude`
* **core:** `Cfn` prefix was added to the following types: `CfnCreationPolicy`, `CfnResourceAutoScalingCreationPolicy`, `CfnResourceAutoScalingCreationPolicy`, `CfnDeletionPolicy`, `CfnUpdatePolicy`, `CfnAutoScalingRollingUpdate`, `CfnAutoScalingReplacingUpdate`, `CfnAutoScalingScheduledAction`, `CfnCodeDeployLambdaAliasUpdate`, `CfnTag` `CfnRuleAssertion`, `CfnDynamicReferenceProps`
* **core:** `deepMerge` is no longer exported.
* **core:** `CfnOutputProps.export` was renamed to `exportName`.
* **core:** `CfnOutput` all properties are now private
* **core:** `StringListCfnOutput` has been removed

Author: Elad Ben-Israel

packages/@aws-cdk/aws-apigateway/lib/api-key.ts

@@ -92,11 +92,11 @@ export class ApiKey extends Resource implements IApiKey {
       description: props.description,
       enabled: props.enabled || true,
       generateDistinctId: props.generateDistinctId,
-      name: this.physicalName.value,
+      name: this.physicalName,
       stageKeys: this.renderStageKeys(props.resources)
     });
 
-    this.keyId = resource.refAsString;
+    this.keyId = resource.ref;
   }
 
   private renderStageKeys(resources: RestApi[] | undefined): CfnApiKey.StageKeyProperty[] | undefined {

packages/@aws-cdk/aws-apigateway/lib/deployment.ts

@@ -1,4 +1,4 @@
-import { Construct, DeletionPolicy, Lazy, Resource, Stack } from '@aws-cdk/cdk';
+import { CfnDeletionPolicy, Construct, Lazy, Resource, Stack } from '@aws-cdk/cdk';
 import crypto = require('crypto');
 import { CfnDeployment, CfnDeploymentProps } from './apigateway.generated';
 import { IRestApi } from './restapi';
@@ -72,11 +72,11 @@ export class Deployment extends Resource {
     });
 
     if (props.retainDeployments) {
-      this.resource.options.deletionPolicy = DeletionPolicy.Retain;
+      this.resource.options.deletionPolicy = CfnDeletionPolicy.Retain;
     }
 
     this.api = props.api;
-    this.deploymentId = Lazy.stringValue({ produce: () => this.resource.refAsString });
+    this.deploymentId = Lazy.stringValue({ produce: () => this.resource.ref });
   }
 
   /**

packages/@aws-cdk/aws-apigateway/lib/method.ts

@@ -123,7 +123,7 @@ export class Method extends Resource {
 
     const resource = new CfnMethod(this, 'Resource', methodProps);
 
-    this.methodId = resource.refAsString;
+    this.methodId = resource.ref;
 
     props.resource.restApi._attachMethod(this);
 

packages/@aws-cdk/aws-apigateway/lib/resource.ts

@@ -211,7 +211,7 @@ export class Resource extends ResourceBase {
     };
     const resource = new CfnResource(this, 'Resource', resourceProps);
 
-    this.resourceId = resource.refAsString;
+    this.resourceId = resource.ref;
     this.restApi = props.parent.restApi;
 
     // render resource path (special case for root)

packages/@aws-cdk/aws-apigateway/lib/restapi.ts

@@ -203,7 +203,7 @@ export class RestApi extends Resource implements IRestApi {
     });
 
     const resource = new CfnRestApi(this, 'Resource', {
-      name: this.physicalName.value!,
+      name: this.physicalName,
       description: props.description,
       policy: props.policy,
       failOnWarnings: props.failOnWarnings,
@@ -215,7 +215,7 @@ export class RestApi extends Resource implements IRestApi {
       parameters: props.parameters,
     });
 
-    this.restApiId = resource.refAsString;
+    this.restApiId = resource.ref;
 
     this.configureDeployment(props);
 

packages/@aws-cdk/aws-apigateway/lib/stage.ts

@@ -197,7 +197,7 @@ export class Stage extends Resource {
       methodSettings,
     });
 
-    this.stageName = resource.refAsString;
+    this.stageName = resource.ref;
     this.restApi = props.deployment.api;
   }
 

packages/@aws-cdk/aws-apigateway/lib/usage-plan.ts

@@ -165,7 +165,7 @@ export class UsagePlan extends Resource {
 
     this.apiStages.push(...(props.apiStages || []));
 
-    this.usagePlanId = resource.refAsString;
+    this.usagePlanId = resource.ref;
 
     // Add ApiKey when
     if (props.apiKey) {

packages/@aws-cdk/aws-apigateway/lib/vpc-link.ts

@@ -47,12 +47,12 @@ export class VpcLink extends Resource {
     });
 
     const cfnResource = new CfnVpcLink(this, 'Resource', {
-      name: this.physicalName.value!,
+      name: this.physicalName,
       description: props.description,
       targetArns: Lazy.listValue({ produce: () => this.renderTargets() })
     });
 
-    this.vpcLinkId = cfnResource.refAsString;
+    this.vpcLinkId = cfnResource.ref;
 
     if (props.targets) {
       this.addTargets(...props.targets);

packages/@aws-cdk/aws-apigateway/package.json

@@ -99,8 +99,8 @@
       "props-physical-name:@aws-cdk/aws-apigateway.MethodProps",
       "props-physical-name:@aws-cdk/aws-apigateway.ProxyResourceProps",
       "props-physical-name:@aws-cdk/aws-apigateway.ResourceProps",
-      "props-physical-name:@aws-cdk/aws-apigateway.StageProps",
       "props-physical-name:@aws-cdk/aws-apigateway.UsagePlanProps",
+      "props-physical-name-type:@aws-cdk/aws-apigateway.StageProps.stageName",
       "props-physical-name:@aws-cdk/aws-apigateway.LambdaRestApiProps"
     ]
   },

packages/@aws-cdk/aws-apigateway/test/test.lambda-api.ts

@@ -81,7 +81,7 @@ export = {
       runtime: lambda.Runtime.Nodejs810,
     });
     const alias = new lambda.Alias(stack, 'alias', {
-      aliasName: cdk.PhysicalName.of('my-alias'),
+      aliasName: 'my-alias',
       version: new lambda.Version(stack, 'version', {
         lambda: handler
       })