feat(core): Add construct.node.stack attribute (#1753)

Makes it easier to access some construct's `Stack`, avoiding
having to sprinkle `Stack.find(this)` everywhere.

BREAKING CHANGE: `Stack.find(c)` and `Stack.tryFind(c)` were
replaced by `c.node.stack`.

Fixes #798

Author: RomainMuller

packages/@aws-cdk/app-delivery/lib/pipeline-deploy-stack-action.ts

@@ -104,7 +104,7 @@ export class PipelineDeployStackAction extends cdk.Construct {
   constructor(scope: cdk.Construct, id: string, props: PipelineDeployStackActionProps) {
     super(scope, id);
 
-    if (!cdk.environmentEquals(props.stack.env, cdk.Stack.find(this).env)) {
+    if (!cdk.environmentEquals(props.stack.env, this.node.stack.env)) {
       // FIXME: Add the necessary to extend to stacks in a different account
       throw new Error(`Cross-environment deployment is not supported`);
     }

packages/@aws-cdk/aws-apigateway/lib/integrations/aws.ts

@@ -73,7 +73,7 @@ export class AwsIntegration extends Integration {
       integrationHttpMethod: 'POST',
       uri: new cdk.Token(() => {
         if (!this.scope) { throw new Error('AwsIntegration must be used in API'); }
-        return cdk.Stack.find(this.scope).formatArn({
+        return this.scope.node.stack.formatArn({
           service: 'apigateway',
           account: backend,
           resource: apiType,

packages/@aws-cdk/aws-apigateway/lib/method.ts

@@ -189,7 +189,7 @@ export class Method extends cdk.Construct {
     } else if (options.credentialsPassthrough) {
       // arn:aws:iam::*:user/*
       // tslint:disable-next-line:max-line-length
-      credentials = cdk.Stack.find(this).formatArn({ service: 'iam', region: '', account: '*', resource: 'user', sep: '/', resourceName: '*' });
+      credentials = this.node.stack.formatArn({ service: 'iam', region: '', account: '*', resource: 'user', sep: '/', resourceName: '*' });
     }
 
     return {

packages/@aws-cdk/aws-apigateway/lib/restapi.ts

@@ -271,7 +271,7 @@ export class RestApi extends cdk.Construct implements IRestApi {
       method = '*';
     }
 
-    return cdk.Stack.find(this).formatArn({
+    return this.node.stack.formatArn({
       service: 'execute-api',
       resource: this.restApiId,
       sep: '/',
@@ -328,7 +328,7 @@ export class RestApi extends cdk.Construct implements IRestApi {
   private configureCloudWatchRole(apiResource: CfnRestApi) {
     const role = new iam.Role(this, 'CloudWatchRole', {
       assumedBy: new iam.ServicePrincipal('apigateway.amazonaws.com'),
-      managedPolicyArns: [ cdk.Stack.find(this).formatArn({
+      managedPolicyArns: [ this.node.stack.formatArn({
         service: 'iam',
         region: '',
         account: 'aws',

packages/@aws-cdk/aws-apigateway/lib/stage.ts

@@ -1,5 +1,4 @@
 import cdk = require('@aws-cdk/cdk');
-import { Stack } from '@aws-cdk/cdk';
 import { CfnStage } from './apigateway.generated';
 import { Deployment } from './deployment';
 import { IRestApi } from './restapi';
@@ -179,8 +178,7 @@ export class Stage extends cdk.Construct {
     if (!path.startsWith('/')) {
       throw new Error(`Path must begin with "/": ${path}`);
     }
-    const stack = Stack.find(this);
-    return `https://${this.restApi.restApiId}.execute-api.${stack.region}.${stack.urlSuffix}/${this.stageName}${path}`;
+    return `https://${this.restApi.restApiId}.execute-api.${this.node.stack.region}.${this.node.stack.urlSuffix}/${this.stageName}${path}`;
   }
 
   private renderMethodSettings(props: StageProps): CfnStage.MethodSettingProperty[] | undefined {

packages/@aws-cdk/aws-cloudformation/lib/pipeline-actions.ts

@@ -544,7 +544,7 @@ class SingletonPolicy extends cdk.Construct {
   }
 
   private stackArnFromProps(props: { stackName: string, region?: string }): string {
-    return cdk.Stack.find(this).formatArn({
+    return this.node.stack.formatArn({
       region: props.region,
       service: 'cloudformation',
       resource: 'stack',

packages/@aws-cdk/aws-cloudformation/test/test.pipeline-actions.ts

@@ -293,7 +293,7 @@ function _isOrContains(entity: string | string[], value: string): boolean {
 }
 
 function _stackArn(stackName: string, scope: cdk.IConstruct): string {
-  return cdk.Stack.find(scope).formatArn({
+  return scope.node.stack.formatArn({
     service: 'cloudformation',
     resource: 'stack',
     resourceName: `${stackName}/*`,
@@ -308,7 +308,7 @@ class PipelineDouble extends cdk.Construct implements cpapi.IPipeline {
   constructor(scope: cdk.Construct, id: string, { pipelineName, role }: { pipelineName?: string, role: iam.Role }) {
     super(scope, id);
     this.pipelineName = pipelineName || 'TestPipeline';
-    this.pipelineArn = cdk.Stack.find(this).formatArn({ service: 'codepipeline', resource: 'pipeline', resourceName: this.pipelineName });
+    this.pipelineArn = this.node.stack.formatArn({ service: 'codepipeline', resource: 'pipeline', resourceName: this.pipelineName });
     this.role = role;
   }
 

packages/@aws-cdk/aws-cloudtrail/lib/index.ts

@@ -132,15 +132,13 @@ export class CloudTrail extends cdk.Construct {
     const s3bucket = new s3.Bucket(this, 'S3', {encryption: s3.BucketEncryption.Unencrypted});
     const cloudTrailPrincipal = "cloudtrail.amazonaws.com";
 
-    const stack = cdk.Stack.find(this);
-
     s3bucket.addToResourcePolicy(new iam.PolicyStatement()
       .addResource(s3bucket.bucketArn)
       .addActions('s3:GetBucketAcl')
       .addServicePrincipal(cloudTrailPrincipal));
 
     s3bucket.addToResourcePolicy(new iam.PolicyStatement()
-      .addResource(s3bucket.arnForObjects(`AWSLogs/${stack.accountId}/*`))
+      .addResource(s3bucket.arnForObjects(`AWSLogs/${this.node.stack.accountId}/*`))
       .addActions("s3:PutObject")
       .addServicePrincipal(cloudTrailPrincipal)
       .setCondition("StringEquals", {'s3:x-amz-acl': "bucket-owner-full-control"}));

packages/@aws-cdk/aws-cloudwatch/lib/dashboard.ts

@@ -1,4 +1,4 @@
-import { Construct, Stack, Token } from "@aws-cdk/cdk";
+import { Construct, Token } from "@aws-cdk/cdk";
 import { CfnDashboard } from './cloudwatch.generated';
 import { Column, Row } from "./layout";
 import { IWidget } from "./widget";
@@ -61,7 +61,6 @@ export class Dashboard extends Construct {
    */
   private generateDashboardName(): string {
     // Combination of stack name and LogicalID, which are guaranteed to be unique.
-    const stack = Stack.find(this);
-    return stack.name + '-' + this.dashboard.logicalId;
+    return this.node.stack.name + '-' + this.dashboard.logicalId;
   }
 }

packages/@aws-cdk/aws-codebuild/lib/project.ts

@@ -409,7 +409,7 @@ class ImportedProject extends ProjectBase {
   constructor(scope: cdk.Construct, id: string, private readonly props: ProjectImportProps) {
     super(scope, id);
 
-    this.projectArn = cdk.Stack.find(this).formatArn({
+    this.projectArn = this.node.stack.formatArn({
       service: 'codebuild',
       resource: 'project',
       resourceName: props.projectName,
@@ -744,7 +744,7 @@ export class Project extends ProjectBase {
   }
 
   private createLoggingPermission() {
-    const logGroupArn = cdk.Stack.find(this).formatArn({
+    const logGroupArn = this.node.stack.formatArn({
       service: 'logs',
       resource: 'log-group',
       sep: ':',