fix(core): UpdateReplacePolicy mirrors DeletionPolicy (#3217)

When setting the DeletionPolicy, the UpdateReplacePolicy should also be
set. There's the same implication of data loss for one and the other.

Fixes #2901.

Author: rix0rrr

packages/@aws-cdk/app-delivery/test/integ.cicd.expected.json

@@ -2,7 +2,8 @@
   "Resources": {
     "ArtifactBucket7410C9EF": {
       "Type": "AWS::S3::Bucket",
-      "DeletionPolicy": "Delete"
+      "DeletionPolicy": "Delete",
+      "UpdateReplacePolicy": "Delete"
     },
     "CodePipelineRoleB3A660B4": {
       "Type": "AWS::IAM::Role",

packages/@aws-cdk/aws-apigateway/lib/deployment.ts

@@ -1,4 +1,4 @@
-import { CfnDeletionPolicy, Construct, Lazy, Resource, Stack } from '@aws-cdk/core';
+import { Construct, Lazy, RemovalPolicy, Resource, Stack } from '@aws-cdk/core';
 import crypto = require('crypto');
 import { CfnDeployment, CfnDeploymentProps } from './apigateway.generated';
 import { IRestApi } from './restapi';
@@ -72,7 +72,7 @@ export class Deployment extends Resource {
     });
 
     if (props.retainDeployments) {
-      this.resource.cfnOptions.deletionPolicy = CfnDeletionPolicy.RETAIN;
+      this.resource.applyRemovalPolicy(RemovalPolicy.RETAIN);
     }
 
     this.api = props.api;

packages/@aws-cdk/aws-apigateway/test/integ.restapi.expected.json

@@ -26,7 +26,8 @@
         "myapiv1toysPUT59AFBBC2",
         "myapiv1toysA55FCBC4"
       ],
-      "DeletionPolicy": "Retain"
+      "DeletionPolicy": "Retain",
+      "UpdateReplacePolicy": "Retain"
     },
     "myapiDeploymentStagebeta96434BEB": {
       "Type": "AWS::ApiGateway::Stage",

packages/@aws-cdk/aws-apigateway/test/test.deployment.ts

@@ -99,7 +99,8 @@ export = {
           Ref: "apiC8550315"
           }
         },
-        DeletionPolicy: "Retain"
+        DeletionPolicy: "Retain",
+        UpdateReplacePolicy: "Retain"
         }
       }
     });

packages/@aws-cdk/aws-cloudformation/test/integ.trivial-lambda-resource.expected.json

@@ -11,7 +11,8 @@
         },
         "Message": "CustomResource says hello"
       },
-      "DeletionPolicy": "Delete"
+      "DeletionPolicy": "Delete",
+      "UpdateReplacePolicy": "Delete"
     },
     "SingletonLambdaf7d4f7304ee111e89c2dfa7ae01bbebcServiceRoleFE9ABB04": {
       "Type": "AWS::IAM::Role",
@@ -86,4 +87,4 @@
       }
     }
   }
-}
+}

packages/@aws-cdk/aws-cloudformation/test/test.resource.ts

@@ -50,6 +50,7 @@ export = testCase({
       // THEN
       expect(stack).to(haveResource('AWS::CloudFormation::CustomResource', {
         DeletionPolicy: 'Retain',
+        UpdateReplacePolicy: 'Retain',
       }, ResourcePart.CompleteDefinition));
 
       test.done();
@@ -112,6 +113,7 @@ export = testCase({
         "Custom1D319B237": {
           "Type": "AWS::CloudFormation::CustomResource",
           "DeletionPolicy": "Delete",
+          "UpdateReplacePolicy": "Delete",
           "Properties": {
             "ServiceToken": {
               "Fn::GetAtt": [
@@ -124,6 +126,7 @@ export = testCase({
         "Custom2DD5FB44D": {
           "Type": "AWS::CloudFormation::CustomResource",
           "DeletionPolicy": "Delete",
+          "UpdateReplacePolicy": "Delete",
           "Properties": {
             "ServiceToken": {
               "Fn::GetAtt": [

packages/@aws-cdk/aws-cloudfront/test/integ.cloudfront-bucket-logging.expected.json

@@ -2,6 +2,7 @@
   "Resources": {
     "Bucket83908E77": {
       "DeletionPolicy": "Delete",
+      "UpdateReplacePolicy": "Delete",
       "Type": "AWS::S3::Bucket"
     },
     "AnAmazingWebsiteProbablyCFDistribution47E3983B": {
@@ -72,7 +73,8 @@
     },
     "AnAmazingWebsiteProbably2LoggingBucket222F7CE9": {
       "Type": "AWS::S3::Bucket",
-      "DeletionPolicy": "Retain"
+      "DeletionPolicy": "Retain",
+      "UpdateReplacePolicy": "Retain"
     },
     "AnAmazingWebsiteProbably2CFDistribution7C1CCD12": {
       "Type": "AWS::CloudFront::Distribution",
@@ -140,4 +142,4 @@
       }
     }
   }
-}
+}

packages/@aws-cdk/aws-cloudfront/test/integ.cloudfront-ipv6-disabled.expected.json

@@ -2,6 +2,7 @@
   "Resources": {
     "Bucket83908E77": {
       "DeletionPolicy": "Delete",
+      "UpdateReplacePolicy": "Delete",
       "Type": "AWS::S3::Bucket"
     },
     "MyDistributionCFDistributionDE147309": {
@@ -51,4 +52,4 @@
       }
     }
   }
-}
+}

packages/@aws-cdk/aws-cloudfront/test/integ.cloudfront-lambda-association.expected.json

@@ -2,6 +2,7 @@
   "Resources": {
     "Bucket83908E77": {
       "DeletionPolicy": "Delete",
+      "UpdateReplacePolicy": "Delete",
       "Type": "AWS::S3::Bucket"
     },
     "LambdaServiceRoleA8ED4D3B": {

packages/@aws-cdk/aws-cloudfront/test/integ.cloudfront-s3.expected.json

@@ -2,6 +2,7 @@
   "Resources": {
     "Bucket83908E77": {
       "DeletionPolicy": "Delete",
+      "UpdateReplacePolicy": "Delete",
       "Type": "AWS::S3::Bucket"
     },
     "BucketPolicyE9A3008A": {