Skip to content

Commit

Permalink
fix(lambda-nodejs): pnpm no longer supports nodejs14.x (backport #24821
Browse files Browse the repository at this point in the history
…) (#24829)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
corymhall authored Mar 28, 2023
1 parent 8b26382 commit e8e4d83
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-lambda-nodejs/lib/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# The correct AWS SAM build image based on the runtime of the function will be
# passed as build arg. The default allows to do `docker build .` when testing.
ARG IMAGE=public.ecr.aws/sam/build-nodejs14.x
ARG IMAGE=public.ecr.aws/sam/build-nodejs18.x
FROM $IMAGE

# Install yarn
Expand Down
5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-lambda-nodejs/test/docker.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import { spawnSync } from 'child_process';
import * as path from 'path';

const docker = process.env.CDK_DOCKER ?? 'docker';
beforeAll(() => {
spawnSync('docker', ['build', '-t', 'esbuild', path.join(__dirname, '../lib')]);
const process = spawnSync(docker, ['build', '-t', 'esbuild', path.join(__dirname, '../lib')], { stdio: 'inherit' });
expect(process.error).toBeUndefined();
expect(process.status).toBe(0);
});

test('esbuild is available', () => {
Expand Down

0 comments on commit e8e4d83

Please sign in to comment.