-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws-codepipeline-actions] Support for CodeStar Connections in GitHubSourceAction #10632
Comments
Hey @akuma12 , actually, you can try using the (poorly name) Let me know if it does. If it turns out it does, we might think of renaming it to make it more obvious it works for both. Thanks, |
@skinny85 I never would have thought of that, I'll give it a whirl, thanks! |
@skinny85 That seems to work. I had an issue at first with the Source action getting triggered by a push, but then just hanging, but it started working after I did a little tear down and redeploy. Thank you so much! |
Sure 🙂. Re-opening so we can track the re-naming work. |
I started to migrate to using I have a situation where I want to Is this a limitation of AWS Codestar or can anyone think of a fancy way to accomplish disabling the trigger without having to manage something like pushing code to S3 and sourcing from there? |
If this is going to replace the GitHubSourceAction it would be nice if it would also emit the variables that are emitted by GitHubSourceAction. |
Poorly named indeed XD Thank you ! @skinny85 |
@skinny85 will this get renamed or should we just use BitBucketSourceAction? |
There will be a new Action class created, something like |
Updating in case someone finds this issue: The Github Version 2 Source action now supports this via |
…tion At the same time, deprecate the unfortunately-named `BitBucketSourceAction`. Fixes aws#10632
any updates? if you know this PR will go through in the next few days, i can postpone development of our companies pipelines for until then. if not i guess i'll have to use the |
Go ahead and use |
…tion At the same time, deprecate the unfortunately-named `BitBucketSourceAction`. Fixes aws#10632
|
How do we access variables with this now? |
@contrapunctus-xv we don't support variables on In the meantime, you can work around this limitation by setting the new codepipeline_actions.CodeStarConnectionsSourceAction({
actionName: 'BitBucket',
owner: 'aws',
repo: 'aws-cdk',
output: sourceOutput,
connectionArn: 'arn:aws:codestar-connections:us-east-1:123456789012:connection/12345678-abcd-12ab-34cdef5678gh',
variablesNamespace: 'MyNamespace',
}), And then using the new cpactions.CodeBuildAction({
actionName: 'Build',
project: new codebuild.PipelineProject(stack, 'MyProject'),
input: sourceOutput,
environmentVariables: {
AuthorDate: { value: '#{MyNamespace.AuthorDate}' },
},
}), Hope this helps! Thanks, |
CodePipeline is recommending the use of the new CodeStar Connections when creating GitHub source actions. The GitHubSourceAction class doesn't currently support passing in a CodeStar Connection ARN.
Use Case
This would allow us to create GitHub sources that utilize the AWS Github Connector app. We can set this up via CloudFormation, but currently not via CDK. This would also have the side effect of enabling GitHub Enterprise Server connections within CDK.
Proposed Solution
Implement a new CodeStarSourceConnectionAction that mimics the parameters defined inhttps://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html
Other
The current GitHubSourceAction is working for us, but the new CodeStar Connection system would be a nice option, and more secure than using a machine account with a personal OAuth token.
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: