-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline-actions): introduce the CodeStarConnectionsSourceAction #13781
Conversation
|
||
private readonly props: BitBucketSourceActionProps; | ||
private readonly codeStartConnectionsSourceAction: CodeStarConnectionsSourceAction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be
private readonly codeStarConnectionsSourceAction: CodeStarConnectionsSourceAction;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Good eye @nathanyocum-ridgeline 🔎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the code, seems like most of is it introducing the same logic as in BitBucketSourceAction
under CodeStarConnectionsSourceAction
? If so, looks good to me. Approving, let me know if you want me to do a more thorough pass
…tion At the same time, deprecate the unfortunately-named `BitBucketSourceAction`. Fixes aws#10632
30b7cc1
to
6c75dd2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
At the same time, deprecate the unfortunately-named
BitBucketSourceAction
.Fixes #10632
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license