feat(codepipeline-actions): introduce the CodeStarConnectionsSourceAction#13781
Merged
mergify[bot] merged 1 commit intoaws:masterfrom Apr 7, 2021
Merged
Conversation
|
|
nat-rl
reviewed
Mar 26, 2021
| public readonly actionProperties: codepipeline.ActionProperties; | ||
|
|
||
| private readonly props: BitBucketSourceActionProps; | ||
| private readonly codeStartConnectionsSourceAction: CodeStarConnectionsSourceAction; |
There was a problem hiding this comment.
should this be
private readonly codeStarConnectionsSourceAction: CodeStarConnectionsSourceAction;
Contributor
Author
There was a problem hiding this comment.
Yep! Good eye @nathanyocum-ridgeline 🔎
NetaNir
approved these changes
Apr 7, 2021
Contributor
NetaNir
left a comment
NetaNir
left a comment
There was a problem hiding this comment.
I looked through the code, seems like most of is it introducing the same logic as in BitBucketSourceAction under CodeStarConnectionsSourceAction ? If so, looks good to me. Approving, let me know if you want me to do a more thorough pass
…tion At the same time, deprecate the unfortunately-named `BitBucketSourceAction`. Fixes aws#10632
skinny85
force-pushed
the
chore/deprecate-bitbucket-action
branch
from
30b7cc1 to
6c75dd2
Compare
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the same time, deprecate the unfortunately-named
BitBucketSourceAction.Fixes #10632
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license