feat(codepipeline-actions): Add detectChanges option to BitBucketSourceAction #13656
Conversation
|
|
|
@skinny85 no rush, but can I get a review when you get a chance :) |
skinny85
added
the
pr-linter/exempt-readme
There was a problem hiding this comment.
Looks great @bryan-hunter! I just have one question/comment about the name.
| @@ -80,11 +80,51 @@ nodeunitShim({ | |||
| }, | |||
| })); | |||
|
|
|||
| test.done(); | |||
| }, | |||
There was a problem hiding this comment.
Add an empty line after this line.
| test.done(); | ||
| }, | ||
| }); | ||
|
|
||
| function createBitBucketAndCodeBuildPipeline(stack: Stack, props: { codeBuildCloneOutput: boolean }): void { | ||
| function createBitBucketAndCodeBuildPipeline(stack: Stack, props: Partial<cpactions.BitBucketSourceActionProps>): void { |
| * @default true | ||
| * @see https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html | ||
| */ | ||
| readonly detectChanges?: boolean; |
There was a problem hiding this comment.
I'm not crazy about this name.
How about triggerOnPush?
There was a problem hiding this comment.
changed to this
…/aws-cdk into codepipeline-detect-changes
There was a problem hiding this comment.
Awesome @bryan-hunter , thanks so much for the contribution!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
skinny85
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ceAction (#13656) Adds optional `DetectChanges` to BitBucketSourceAction https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html This option is available in the AWS console when configuring the Source stage. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ceAction (aws#13656) Adds optional `DetectChanges` to BitBucketSourceAction https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html This option is available in the AWS console when configuring the Source stage. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds optional
DetectChangesto BitBucketSourceActionhttps://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html
This option is available in the AWS console when configuring the Source stage.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license