Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): incorrect policy for Athena prevents database deletions #11427

Merged
merged 5 commits into from
Nov 12, 2020

Conversation

amitkumardeol
Copy link
Contributor

@amitkumardeol amitkumardeol commented Nov 11, 2020

Updated the resource name from userdefinedfunction to userDefinedFunction.

closes #11357


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Updated the resource name from `userdefinedfunction` to `userDefinedFunction`. This will reflect the correct arn for user-defined function as mentioned on page 257 in https://docs.aws.amazon.com/athena/latest/ug/athena-ug.pdf
Incorrect ARN: `arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:userdefinedfunction/*`
After applying the change correct ARN: `arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:userDefinedFunction/*`
@gitpod-io
Copy link

gitpod-io bot commented Nov 11, 2020

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@amitkumardeol amitkumardeol changed the title fix(stepfunctions-tasks): Fixed the Athena policy issue to allow access to userDefinedFunction ARN [WIP] fix(stepfunctions-tasks): Fixed the Athena policy issue to allow access to userDefinedFunction ARN Nov 11, 2020
@shivlaks shivlaks marked this pull request as draft November 11, 2020 18:44
@shivlaks shivlaks changed the title [WIP] fix(stepfunctions-tasks): Fixed the Athena policy issue to allow access to userDefinedFunction ARN fix(stepfunctions-tasks): incorrect policy for Athena prevents database deletions Nov 11, 2020
@shivlaks
Copy link
Contributor

@amitkumardeol thanks for submitting this fix!!

I've marked this as a draft, re-titled the issue as per our CONTRIBUTING guide and linked it to the issue it resolves.

feel free to mark it ready for review when it's ready!

Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkumardeol - I updated the tests

@shivlaks shivlaks marked this pull request as ready for review November 12, 2020 21:56
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 58e6576 into aws:master Nov 12, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 762a4c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-stepfunctions-tasks: Athena policy incorrect, preventing database deletions
3 participants