-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): incorrect policy for Athena prevents database deletions #11427
Conversation
Updated the resource name from `userdefinedfunction` to `userDefinedFunction`. This will reflect the correct arn for user-defined function as mentioned on page 257 in https://docs.aws.amazon.com/athena/latest/ug/athena-ug.pdf Incorrect ARN: `arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:userdefinedfunction/*` After applying the change correct ARN: `arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:userDefinedFunction/*`
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
@amitkumardeol thanks for submitting this fix!! I've marked this as a draft, re-titled the issue as per our CONTRIBUTING guide and linked it to the issue it resolves. feel free to mark it ready for review when it's ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitkumardeol - I updated the tests
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Updated the resource name from
userdefinedfunction
touserDefinedFunction
.closes #11357
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license