Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appmesh] implement Route Timeout feature #11643

Closed
2 tasks
dfezzie opened this issue Nov 23, 2020 · 1 comment · Fixed by #11973 · May be fixed by skiyani/aws-cdk#3
Closed
2 tasks

[appmesh] implement Route Timeout feature #11643

dfezzie opened this issue Nov 23, 2020 · 1 comment · Fixed by #11973 · May be fixed by skiyani/aws-cdk#3
Assignees
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Milestone

Comments

@dfezzie
Copy link
Contributor

dfezzie commented Nov 23, 2020

App Mesh supports the configuration of Timeouts on the route resource. These should be configurable by the customer

Use Case

Customers should be able to configure the request timeoutes for their routes

Proposed Solution

For each route protocol, the retry policies should be configurable

router.addRoute('test-http-route', {
  routeSpec: appmesh.RouteSpec.http({
    idleTimeout: cdk.Duration.seconds(15),
    requestTimeout: cdk.Duration.seconds(5),
    ...
    weightedTargets: [
      {
         virtualNode: node,
      },
    ],
  }),
});

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@dfezzie dfezzie added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 23, 2020
@github-actions github-actions bot added the @aws-cdk/aws-appmesh Related to AWS App Mesh label Nov 23, 2020
@skinny85 skinny85 added this to the [DevPreview] AppMesh milestone Dec 1, 2020
@skinny85 skinny85 added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2020
@mergify mergify bot closed this as completed in #11973 Dec 15, 2020
mergify bot pushed a commit that referenced this issue Dec 15, 2020
Add support to http/http2/grpc/tpc route timeouts. 

Reference links for [HttpTimeout](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appmesh-route-httptimeout.html), [GrpcTimeout](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appmesh-route-grpctimeout.html), and [TcpTimeout](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appmesh-route-tcptimeout.html). (Http2 uses the HttpTimeout object).

closes #11643

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
Add support to http/http2/grpc/tpc route timeouts. 

Reference links for [HttpTimeout](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appmesh-route-httptimeout.html), [GrpcTimeout](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appmesh-route-grpctimeout.html), and [TcpTimeout](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appmesh-route-tcptimeout.html). (Http2 uses the HttpTimeout object).

closes aws#11643

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
2 participants