Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[appmesh] implement Outlier Detection for Virtual Nodes #11648

Closed
2 tasks
dfezzie opened this issue Nov 23, 2020 · 2 comments
Closed
2 tasks

[appmesh] implement Outlier Detection for Virtual Nodes #11648

dfezzie opened this issue Nov 23, 2020 · 2 comments
Assignees
@skinny85
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Milestone
[GA] AppMesh

Comments

@dfezzie
Copy link
Contributor

dfezzie commented Nov 23, 2020

Use Case

Customers should be able to configure outlier detection for Virtual Node listeners in their mesh. This allows them to eject hosts that are not behaving as expected. This should be implemented for each Virtual Node listener protocol spec

Proposed Solution

Example:

new appmesh.VirtualNode(stack, 'test-node', {
  ...
  listeners: [
    appmesh.VirtualNodeListener.http({
      port: 80,
      outlierDetection: {
        baseEjectionDuration: cdk.Duration.seconds(10),
        interval: cdk.Duration.seconds(30),
        maxEjectionPercent: 50,
        maxServerErrors: 5,
      },
    }),
  ],
});

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@dfezzie dfezzie added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 23, 2020
@github-actions github-actions bot added the @aws-cdk/aws-appmesh Related to AWS App Mesh label Nov 23, 2020
@dfezzie dfezzie mentioned this issue Nov 23, 2020
Open
9 tasks
@skinny85 skinny85 added this to the [DevPreview] AppMesh milestone Dec 1, 2020
@skinny85 skinny85 added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2020
alexbrjo pushed a commit to alexbrjo/aws-cdk that referenced this issue Apr 2, 2021
Implement Outlier Detection for Virtual Nodes
5e0e90e 
issue aws#11648
@alexbrjo alexbrjo mentioned this issue Apr 2, 2021
Merged
mergify bot pushed a commit that referenced this issue Apr 5, 2021
@alexbrjo
feat(appmesh): Implement Outlier Detection for Virtual Nodes (#13952)
965f130 
This is a pretty short PR adding outlier detection to Virtual Node listeners. See below for usage. 

```ts
const node = mesh.addVirtualNode('virtual-node', {
  serviceDiscovery: appmesh.ServiceDiscovery.cloudMap({
    service: service,
  }),
  outlierDetection: {
    baseEjectionDuration: cdk.Duration.seconds(10),
    interval: cdk.Duration.seconds(30),
    maxEjectionPercent: 50,
    maxServerErrors: 5,
  },
});
```

Note:
* All the parameters are required and there aren't any combinations of features that get special treatment, so there's only one unit test. 
* We don't do any min/max time evaluation for other features so I followed precedent for that. 

issue #11648

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@dfezzie dfezzie closed this as completed Apr 7, 2021
@dfezzie
Copy link
Contributor Author

dfezzie commented Apr 7, 2021

Resolved with #13952

@github-actions
Copy link

github-actions bot commented Apr 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@alexbrjo @hollanddd
feat(appmesh): Implement Outlier Detection for Virtual Nodes (aws#13952)
b1637ba 
This is a pretty short PR adding outlier detection to Virtual Node listeners. See below for usage. 

```ts
const node = mesh.addVirtualNode('virtual-node', {
  serviceDiscovery: appmesh.ServiceDiscovery.cloudMap({
    service: service,
  }),
  outlierDetection: {
    baseEjectionDuration: cdk.Duration.seconds(10),
    interval: cdk.Duration.seconds(30),
    maxEjectionPercent: 50,
    maxServerErrors: 5,
  },
});
```

Note:
* All the parameters are required and there aren't any combinations of features that get special treatment, so there's only one unit test. 
* We don't do any min/max time evaluation for other features so I followed precedent for that. 

issue aws#11648

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
[GA] AppMesh
Development

No branches or pull requests
2 participants
@skinny85 @dfezzie