Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(eks): support CapacityType CFN property for Nodegroup #12154

Closed
1 of 2 tasks
pahud opened this issue Dec 18, 2020 · 2 comments · Fixed by #12344
Closed
1 of 2 tasks

(eks): support CapacityType CFN property for Nodegroup #12154

pahud opened this issue Dec 18, 2020 · 2 comments · Fixed by #12344
Assignees
@iliapolo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p1

Comments

@pahud
Copy link
Contributor

pahud commented Dec 18, 2020

By the time we have CapacityType in CFN spec, we should use this property instead of property override.

see #11962 (comment)

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 18, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 18, 2020
@pahud pahud mentioned this issue Dec 18, 2020
Merged
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 18, 2020
@pahud
Copy link
Contributor Author

pahud commented Dec 23, 2020 •
edited
Loading

depends #12204

@pahud pahud mentioned this issue Jan 5, 2021
Merged
@mergify mergify bot closed this as completed in #12344 Jan 5, 2021
mergify bot pushed a commit that referenced this issue Jan 5, 2021
@pahud
chore(eks): remove the property override for CapacityType (#12344)
65fde99 
Remove the tentative property override and use the L1 property instead.

Fixes: #12154 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@arniesaha arniesaha mentioned this issue Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(eks): remove the property override for CapacityType
2 participants
@pahud @iliapolo