Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(elasticsearch): Add Support for ElasticSearch Custom Domain Endpoint #12261

Closed
arvinbenitez opened this issue Dec 29, 2020 · 5 comments · Fixed by #12904
Closed

(elasticsearch): Add Support for ElasticSearch Custom Domain Endpoint #12261

arvinbenitez opened this issue Dec 29, 2020 · 5 comments · Fixed by #12904
Assignees
@iliapolo
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@arvinbenitez
Copy link

When creating an ElasticSearch Domain, I want to be able to automate the creation of a custom domain name. Support for this has been recently added (Nov-2020). However, the following properties do not seem to have been implemented in the ElasticSearch package.

Based on the this documenation, it is already supported by Cloudformation. However these properties are not in the latest nuget package (v1.80.0 as of this writing).

The following props need to be implemented in AWS::Elasticsearch::Domain DomainEndpointOptions DomainEndpointOptions

  "CustomEndpoint" : String,
  "CustomEndpointCertificateArn" : String,
  "CustomEndpointEnabled" : Boolean,

This is a 🚀 Feature Request
@arvinbenitez arvinbenitez added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 29, 2020
@hoegertn
Copy link
Contributor

This seems to be a release in progress. The "What's new" of CFN does not cover it yet and it was not there last week. I implemented the custom resource this weekend 😡

So it should be there in the next spec release and then can be added to the L2

@hoegertn
Copy link
Contributor

BTW I am happy to implement this then. I did some work around this like R53, Certificates, etc

@NGL321 NGL321 changed the title (aws_elasticsearch): Add Support for ElasticSearch Custom Domain Endpoint (elasticsearch): Add Support for ElasticSearch Custom Domain Endpoint Feb 1, 2021
@github-actions github-actions bot added the @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service label Feb 1, 2021
@iliapolo
Copy link
Contributor

iliapolo commented Feb 2, 2021

@hoegertn Still up for adding this? Would be great.

@iliapolo iliapolo added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2021
@hoegertn
Copy link
Contributor

hoegertn commented Feb 2, 2021

Sure. Will take a look at this this week

@hoegertn hoegertn mentioned this issue Feb 6, 2021
Merged
@mergify mergify bot closed this as completed in #12904 Feb 10, 2021
mergify bot pushed a commit that referenced this issue Feb 10, 2021
@hoegertn
feat(elasticsearch): add custom endpoint options (#12904)
f67ab86 
Closes #12261 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
@hoegertn @NovakGu
feat(elasticsearch): add custom endpoint options (aws#12904)
ac17846 
Closes aws#12261 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticsearch): add custom endpoint options
3 participants
@hoegertn @iliapolo @arvinbenitez