‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 #12291

pahud · 2020-12-31T01:42:24Z

Please add your +1 👍 to let us know you have encountered this

Status: IN-PROGRESS

Overview

The @aws-cdk/aws-eks and @aws-cdk/aws-s3-deployment modules are broken in v1.81.0 of the AWS CDK due to a missing file in the npm bundle.

Complete Error Message

no such file or directory, open '.../node_modules/@aws-cdk/lambda-layer-???/layer/Dockerfile

Workaround

Until we are able to release a fix, if you are using one of these modules, you have the following workarounds:

Stay on v1.80.0 - this requires that you pin all your CDK dependencies to 1.80.0 instead of using a caret (^) version requirement.
Apply a temporary patch module to your code:

Solution

A solution for the root cause can be found in #12293 and will published as soon as we are able to release the AWS CDK. We will likely be able to release this immediately after New Years Eve 🎉 .

This is 🐛 Bug Report

The text was updated successfully, but these errors were encountered:

pahud · 2020-12-31T01:42:34Z

copy @eladb

pahud · 2020-12-31T02:25:24Z

If you are developing aws cdk constructs with projen like me and your construct depends on aws-eks, consider cdkVersionPinning on 1.80.0 atm.

const project = new AwsCdkConstructLibrary({
  cdkVersion: '1.80.0',
  cdkVersionPinning: true,

eladb · 2020-12-31T06:49:35Z

Shoot. Thanks for reporting. We will issue a patch as soon as possible.

…ing file The `Dockerfile` which we use as the source for layer asset hash calculation was excluded from the npm tarball since it was inside the `layer` directory (which was in .npmignore). This change de-excludes this file. Fixes #12291

eladb · 2020-12-31T08:19:47Z

@pahud can you try the above workaround and let us know if it works for you?

pahud · 2020-12-31T08:37:25Z

@pahud can you try the above workaround and let us know if it works for you?

OK let me try again.

pahud · 2020-12-31T08:52:56Z

Hi @eladb

I fetched the layer directory from your branch into my local @aws-cdk/lambda-layer-awscli/ and @aws-cdk/lambda-layer-kubectl/ under node_modules and now it can deploy with no error.

The PR works!

pahud · 2020-12-31T09:01:12Z

And the workaround patch function works as well.

eladb · 2020-12-31T12:45:47Z

Original issue:

I was developing cdk contructs with the latest v1.81.0 and looks like the Dockerfile is missing in the npm package

cdk --app 'npx ts-node src/integ.default.ts' diff
ENOENT: no such file or directory, open '/Users/pahud/github/cdk-kubesphere/node_modules/@aws-cdk/lambda-layer-awscli/layer/Dockerfile'
Subprocess exited with error 1

aws-cdk/packages/@aws-cdk/lambda-layer-awscli/lib/awscli-layer.ts

Line 15 in c752fab

assetHash: hashFile(path.join(__dirname, '..', 'layer', 'Dockerfile')),

I believe the same error should occur in lambda-layer-kubectl.

We probably should remove this line:

aws-cdk/packages/@aws-cdk/lambda-layer-awscli/.npmignore

Line 28 in 979340e

layer/

Reproduction Steps

What did you expect to happen?

What actually happened?

Environment

**CDK CLI Version : 1.81.0
Framework Version:
Node.js Version:
OS :
Language (Version):

Other

…ing file (#12293) The `layer/Dockerfile` which we use as the source for layer asset hash calculation was excluded from the npm tarball since it was inside the `layer` directory (which was in .npmignore). This change de-excludes this file. Fixes #12291 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions · 2020-12-31T13:41:34Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

kkanchinadam · 2021-01-01T22:34:12Z

Had the same issue. Applying the patch resolved it.

hom-bahrani · 2021-01-02T06:27:20Z

Had the same issue deploying a lambda function via an S3 bucket

const sourceBucket = new s3.Bucket(this, 'LambdaSourceBucket', {
      versioned: true,
      bucketName: 'lambdasourcebucket48257402798011'
    });

    new s3deploy.BucketDeployment(this, 'DeployLambdaCode', {
      sources: [s3deploy.Source.asset('../sqs-lambda/dist.zip')],
      destinationBucket: sourceBucket
    });

tried using version 1.80.0 and 1.79.0 but neither worked. Got the error message ENOENT: no such file or directory, open '.../node_modules/@aws-cdk/lambda-layer-awscli/layer/Dockerfile'

Patch by @pahud is working ok, many thanks

eladb · 2021-01-03T11:12:53Z

We released the fix as part of v1.82.0, the patch is no longer required.

github-actions · 2021-01-03T11:13:17Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

…ing file (aws#12293) The `layer/Dockerfile` which we use as the source for layer asset hash calculation was excluded from the npm tarball since it was inside the `layer` directory (which was in .npmignore). This change de-excludes this file. Fixes aws#12291 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

pahud added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 31, 2020

eladb added p0 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 31, 2020

eladb mentioned this issue Dec 31, 2020

fix(lambda-layer-*): unable to calculate layer asset hash due to missing file #12293

Merged

eladb pinned this issue Dec 31, 2020

eladb changed the title ~~(lambda-layer-awscli): missing Dockerfile~~ aws-eks/aws-s3-deployment broken in v1.81.0 due to missing file from npm tarball Dec 31, 2020

eladb changed the title ~~aws-eks/aws-s3-deployment broken in v1.81.0 due to missing file from npm tarball~~ eks and s3-deployment are broken in v1.81.0 due to missing file from npm tarball Dec 31, 2020

eladb changed the title ~~eks and s3-deployment are broken in v1.81.0 due to missing file from npm tarball~~ eks and s3-deployment are broken in v1.81.0 (missing file from npm tarball) Dec 31, 2020

eladb changed the title ~~eks and s3-deployment are broken in v1.81.0 (missing file from npm tarball)~~ ‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 (missing file from npm tarball) Dec 31, 2020

eladb changed the title ~~‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 (missing file from npm tarball)~~ ‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 Dec 31, 2020

eladb added management/tracking Issues that track a subject or multiple issues @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service @aws-cdk/aws-s3-deployment labels Dec 31, 2020

mergify bot closed this as completed in #12293 Dec 31, 2020

eladb reopened this Dec 31, 2020

iliapolo mentioned this issue Dec 31, 2020

chore: Added notes about broken examples aws-samples/aws-cdk-examples#379

Closed

wballard added a commit to userbugreport/shipula that referenced this issue Jan 1, 2021

pin version because aws/aws-cdk#12291

c73fbcf

This was referenced Jan 2, 2021

pinned version on CDK 1.80.0 aws-samples/amazon-eks-cicd-codebuild#23

Closed

support cdk 1.81.0 with patch aws-samples/amazon-eks-refarch-cloudformation#21

Closed

cdk-patterns mentioned this issue Jan 2, 2021

jsii errors -- nideveloper/CDK-SPA-Deploy#191

Closed

eladb closed this as completed Jan 3, 2021

eladb unpinned this issue Jan 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 #12291

‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 #12291

pahud commented Dec 31, 2020 •

edited by eladb

Loading

pahud commented Dec 31, 2020

pahud commented Dec 31, 2020

eladb commented Dec 31, 2020

eladb commented Dec 31, 2020

pahud commented Dec 31, 2020

pahud commented Dec 31, 2020 •

edited

Loading

pahud commented Dec 31, 2020 •

edited

Loading

eladb commented Dec 31, 2020

github-actions bot commented Dec 31, 2020

kkanchinadam commented Jan 1, 2021

hom-bahrani commented Jan 2, 2021 •

edited

Loading

eladb commented Jan 3, 2021

github-actions bot commented Jan 3, 2021

‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 #12291

‼️ NOTICE: eks and s3-deployment are broken in v1.81.0 #12291

Comments

pahud commented Dec 31, 2020 • edited by eladb Loading

Status: IN-PROGRESS

Overview

Complete Error Message

Workaround

Solution

pahud commented Dec 31, 2020

pahud commented Dec 31, 2020

eladb commented Dec 31, 2020

eladb commented Dec 31, 2020

pahud commented Dec 31, 2020

pahud commented Dec 31, 2020 • edited Loading

pahud commented Dec 31, 2020 • edited Loading

eladb commented Dec 31, 2020

Reproduction Steps

What did you expect to happen?

What actually happened?

Environment

Other

github-actions bot commented Dec 31, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

kkanchinadam commented Jan 1, 2021

hom-bahrani commented Jan 2, 2021 • edited Loading

eladb commented Jan 3, 2021

github-actions bot commented Jan 3, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

pahud commented Dec 31, 2020 •

edited by eladb

Loading

pahud commented Dec 31, 2020 •

edited

Loading

pahud commented Dec 31, 2020 •

edited

Loading

hom-bahrani commented Jan 2, 2021 •

edited

Loading