-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Imagebuilder): cdk diff not detecting changes #13016
Comments
Thanks for reporting @nigel-heaney . Confirming I was able to reproduce it. Digging into this further. |
The problem is this line. Apparently, in JavaScript, |
Turns out, our cloudformation-diff interprets all version strings like '0.2.3' as just 0, which means diff misses any changes to those kind of resources. Make sure that returning the number 0 only happens for strings that are actually equal to '0'. Fixes aws#13016
Turns out, our cloudformation-diff interprets all version strings like '0.2.3' as just 0, which means diff misses any changes to those kind of resources. Make sure that returning the number 0 only happens for strings that are actually equal to '0'. Fixes #13016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Turns out, our cloudformation-diff interprets all version strings like '0.2.3' as just 0, which means diff misses any changes to those kind of resources. Make sure that returning the number 0 only happens for strings that are actually equal to '0'. Fixes aws#13016 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Updating a component or image recipe version is not reflected in cdk diff and will report no changes but a deploy will replace those resources with the new version.
Reproduction Steps
update the versions to 0.0.2 and cdk diff shows
cdk diff Stack ExampleStack There were no differences # then deploy cdk deploy ExampleStack: deploying... ExampleStack: creating CloudFormation changeset... [█████████████████████████████·····························] (2/4) ✅ ExampleStack
What did you expect to happen?
It should report that those resources will be replaced.
Environment
Other
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: