-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ecs): add a portMappings
prop to ContainerDefinition
#13261
Closed
1 of 2 tasks
misterjoshua opened this issue
Feb 24, 2021
· 1 comment
· Fixed by #13262, aws-iot-builder-tools/iot-reference-architectures#1801, aws-samples/keycloak-on-aws#44, aws-samples/keycloak-on-aws#46 or aws-samples/amazon-emr-with-juicefs#80
Closed
1 of 2 tasks
(ecs): add a portMappings
prop to ContainerDefinition
#13261
misterjoshua opened this issue
Feb 24, 2021
· 1 comment
· Fixed by #13262, aws-iot-builder-tools/iot-reference-architectures#1801, aws-samples/keycloak-on-aws#44, aws-samples/keycloak-on-aws#46 or aws-samples/amazon-emr-with-juicefs#80
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
feature-request
A feature should be added or improved.
Comments
misterjoshua
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Feb 24, 2021
mergify bot
pushed a commit
that referenced
this issue
Feb 26, 2021
This PR adds an optional `portMappings` property to `ContainerDefinitionOptions` so that users can add port mappings when they add a container to a `TaskDefinition`. Closes #13261 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Mar 6, 2021
Merged
Closed
Closed
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
feature-request
A feature should be added or improved.
I'd like to allow the user to define port mappings when adding containers to a task definition.
Use Case
This would allow users to add containers in a more declarative fashion.
Proposed Solution
Add an optional
portMappings
prop toContainerDefinitionOptions
and haveContainerDefinition
add the port mappings at construction time. After, I'd be able to do this:This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: